Option to disable updating the facets after each facet selection for Apply/Reset facet buttons block.

I believe the best course of action is to add a new option in the facets block configuration that allows the facet selection auto update for available facets and counts to be disabled.

Patch adds new option to Apply/Reset facet block to disable available facets and facet counts from updating. Default value for block for auto updating is feature is ON.

CommentFileSizeAuthor
#21 disable-auto-refresh-3172373-21.patch17.15 KBphannphong
#20 disable-auto-refresh-3172373-20.patch16.34 KBValentine94
#19 disable-auto-refresh-3172373-19.patch16.18 KBValentine94
#18 disable-auto-refresh-3172373-17.patch14.06 KBValentine94
#16 disable-auto-refresh-3172373-16.patch15.22 KBValentine94
#15 interdiff_12-15.txt3.09 KBvlad.dancer
#15 disable-auto-refresh-3172373-15.patch12.89 KBvlad.dancer
#13 interdiff_12-13.txt1.29 KBvlad.dancer
#13 disable-auto-refresh-3172373-13.patch12.75 KBvlad.dancer
#12 disable-auto-refresh-3172373-12.patch12.68 KBValentine94
#10 disable-auto-refresh-3172373-10.patch11.32 KBValentine94
#8 disable-auto-refresh-3172373-8.patch11.33 KBMistrae
#7 disable-auto-refresh-3172373-7.patch11.29 KBMistrae
#6 disable-auto-refresh-3172373-1-latest.patch11.52 KBBharti Mehta
#4 disable-auto-refresh-3172373-1.patch11.45 KBBharti Mehta
#3 disable-auto-refresh-3172373-test.patch11.45 KBBharti Mehta
#2 disable-auto-refresh-3172373.patch11.73 KBBharti Mehta

Issue fork facets-3172373

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks
    Support from Acquia helps fund testing for Drupal Acquia logo

    Comments

    Bharti Mehta created an issue. See original summary.

    Bharti Mehta’s picture

    Bharti Mehta CreditAttribution: Bharti Mehta commented
    FileSize
    disable-auto-refresh-3172373.patch11.73 KB
    Bharti Mehta’s picture

    Bharti Mehta CreditAttribution: Bharti Mehta commented
    FileSize
    disable-auto-refresh-3172373-test.patch11.45 KB
    Bharti Mehta’s picture

    Bharti Mehta CreditAttribution: Bharti Mehta commented
    FileSize
    disable-auto-refresh-3172373-1.patch11.45 KB
    Bharti Mehta’s picture

    Bharti Mehta CreditAttribution: Bharti Mehta commented
    Version: 8.x-1.x-dev » 8.x-1.4
    Bharti Mehta’s picture

    Bharti Mehta CreditAttribution: Bharti Mehta commented
    FileSize
    disable-auto-refresh-3172373-1-latest.patch11.52 KB
    Mistrae’s picture

    Mistrae CreditAttribution: Mistrae commented
    FileSize
    disable-auto-refresh-3172373-7.patch11.29 KB

    Updated for latest version

    Mistrae’s picture

    Mistrae CreditAttribution: Mistrae commented
    FileSize
    disable-auto-refresh-3172373-8.patch11.33 KB

    Latest patch was buggy with multiple facets.

    dorficus’s picture

    dorficus CreditAttribution: dorficus at EPAM Systems commented

    Checking to see if this is something being considered for inclusion in 3.x? I agree that there should be the option to select multiple facets and then apply them rather than having a page reload/AJAX call each time a box is checked.

    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    Status: Active » Needs review
    FileSize
    disable-auto-refresh-3172373-10.patch11.32 KB

    Patch cleanup and re-roll

    vlad.dancer’s picture

    vlad.dancer
    Primary language Ukrainian
    Location Kyiv
    CreditAttribution: vlad.dancer as a volunteer and at Drupal Ukraine Community for Xspace commented
    Version: 8.x-1.4 » 2.0.x-dev
    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    FileSize
    disable-auto-refresh-3172373-12.patch12.68 KB

    Fixed missing facet source path for submitting and added a way to limit this functionality for specific pages only

    vlad.dancer’s picture

    vlad.dancer
    Primary language Ukrainian
    Location Kyiv
    CreditAttribution: vlad.dancer as a volunteer and at Drupal Ukraine Community for Xspace commented
    FileSize
    disable-auto-refresh-3172373-13.patch12.75 KB
    interdiff_12-13.txt1.29 KB

    Added code guards against empty js settings.

    vlad.dancer’s picture

    vlad.dancer
    Primary language Ukrainian
    Location Kyiv
    CreditAttribution: vlad.dancer as a volunteer and at Drupal Ukraine Community for Xspace commented

    > added a way to limit this functionality for specific pages only

    Then we either need to use condition manager service for correctly checking request path or rely on facet_block with condition_path modules for doing that.
    Currently, a language prefix is not counted when checking requets path.

    vlad.dancer’s picture

    vlad.dancer
    Primary language Ukrainian
    Location Kyiv
    CreditAttribution: vlad.dancer as a volunteer and at Drupal Ukraine Community for Xspace commented
    FileSize
    disable-auto-refresh-3172373-15.patch12.89 KB
    interdiff_12-15.txt3.09 KB

    Used request_path condition plugin to check path in a more accurate way.
    Then we need to add tests and write hook_update for bringing up new config options.

    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    FileSize
    disable-auto-refresh-3172373-16.patch15.22 KB

    Currently, a language prefix is not counted when checking requets path.

    How about this?

    Status: Needs review » Needs work

    The last submitted patch, 16: disable-auto-refresh-3172373-16.patch, failed testing. View results
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    FileSize
    disable-auto-refresh-3172373-17.patch14.06 KB

    Rolled back DI implementation for now to allow tests pass

    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    FileSize
    disable-auto-refresh-3172373-19.patch16.18 KB

    Additional small fixes

    Valentine94’s picture

    Valentine94
    Location Kyiv, Ukraine
    CreditAttribution: Valentine94 commented
    FileSize
    disable-auto-refresh-3172373-20.patch16.34 KB

    Extra condition to prevent wrong behavior

    phannphong’s picture

    phannphong CreditAttribution: phannphong as a volunteer and at FIDESIO, Athena commented
    FileSize
    disable-auto-refresh-3172373-21.patch17.15 KB

    I have made updates based on patch #20 to create a new patch that can be applied to version 3.0.0-beta1.

    liquidcms’s picture

    liquidcms CreditAttribution: liquidcms commented

    [deleted] - js cache not cleared.. all working now:
    - don't submit on checkbox click
    - ajax submit when views exposed form submitted

    Thanks for this :)