Closed (fixed)
Project:
Facebook Pull
Version:
7.x-1.0
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2012 at 20:33 UTC
Updated:
26 Nov 2014 at 16:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rickyd1 commentedOkay I have a fix to this issue:
I am not sure how to create patches as I am green to module development. However, I looked at the API and a tutorial on creating module and found a fix to this.
On line 88 of facebook_pull.module the block is declared with this code
The line that sets the title is:
When it is set, we will not be able to change the title in the configuration screen. However, if we change 'title' to 'subject' , we will be able to change the title. The block will use the subject as the title if we do not set a title in the configuration screen.
Here is the change:
After making this change, my new code looks like this:
It seems to be working fine. Does anyone see any issues with this change that will effect the module?
Comment #2
aidanlis commentedLooks like you are right, I will update the module when I get some spare time.
Comment #3
creact commentedI am having the same issue. Will there be a fix soon?
Comment #4
zr2d2 commentedper [#2], I found this change on the 6.x branch, but not the 7.x branch. here is a patch of #1 for the 7.x branch, which may fix @creact's problem
Comment #5
zr2d2 commentedupdating status, per #3
Comment #7
froboyTested and works but still needs to be committed. Any possibility of getting this in?
Comment #8
kyuubi commentedComment #9
zrowe007 commentedWhat is the process for committing this?
Comment #10
smurfxx commented@zrowe007 in this case you have to change only one row, open the file facebook_pull.module that it's in sites/all/modules/facebook_pull
Search for the row that contains "'title' => t('Facebook stream')," delete it and write this row:
" 'subject' => t('Facebook stream'), "
If in the future you will find bigger patches that this, so I suggest you to inform here
Anyway, this patch works!
Comment #11
zrowe007 commented@smurfxx yes, I am the author of #4 (I had to create a new account), I was wondering if I needed to do anything else to submit this for inclusion (perhaps a git commit).
Comment #12
daveferrara1 commentedPatch Applied.
Comment #14
daveferrara1 commented