Problem/Motivation

External entities with a UUID as ID or any ID containing characters not accepted by hook_theme_suggestions_HOOK() generate unusable template name suggestions. The template name suggestion doesn't work, and could be hard to figure out why. Twig debugging makes notice of this.

it looks like this when twig debugging is enabled:

<!--- 
   INVALID FILE NAME SUGGESTIONS:
   See https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Render!theme.api.php/function/hook_theme_suggestions_alter
   external_entity__b719a2fa-e401-4c97-b0b2-c33cb2a97693__full
   external_entity__b719a2fa-e401-4c97-b0b2-c33cb2a97693 
--->

Steps to reproduce

  1. Configure an external entity using a UUID or other form of ID with illegal template name characters
  2. Enable twig debugging
  3. Visit a page containing an external entity, like the detail page

Proposed resolution

sanitize the ID while generating theme suggestions.

CommentFileSizeAuthor
#4 3419507_adds_sanitation.patch1.28 KBpefferen

Issue fork external_entities-3419507

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pefferen created an issue. See original summary.

pefferen opened merge request !35

pefferen’s picture

pefferen CreditAttribution: pefferen as a volunteer commented
Status: Active » Needs review
pefferen’s picture

pefferen CreditAttribution: pefferen at Kunstmuseum Den Haag, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3419507_adds_sanitation.patch1.28 KB

adding patch file for use in composer