When current user doesn't have access to "administer entityqueue" configure link is appearing without a link, see attachment for more information.

CommentFileSizeAuthor
#7 fix_configure_link-2839334-7.patch670 bytesabu-zakham
#5 fix_configure_link-2839334-5.patch707 bytesabu-zakham
#2 fix_configure_link-2839334-2.patch690 bytesabu-zakham
Entityqueues .png91.67 KBabu-zakham
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

abu-zakham created an issue. See original summary.

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham at Vardot commented
Assigned: abu-zakham » Unassigned
Status: Active » Needs review
FileSize
fix_configure_link-2839334-2.patch690 bytes

This patch fixes the bug.

Regards.

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham at Vardot commented
Title: should check user permission before changing edit link title. » EntityQueueListBuilder should check user permission before changing edit link title.

update title.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Testing ....

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham at Vardot commented
FileSize
fix_configure_link-2839334-5.patch707 bytes
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Needs work 
+++ b/src/EntityQueueListBuilder.php
@@ -139,7 +139,9 @@ class EntityQueueListBuilder extends ConfigEntityListBuilder {
+    if(\Drupal::currentUser()->hasPermission('administer entityqueue')) {
+      $operations['edit']['title'] = $this->t('Configure');
+    }

Since the parent class already has this access check, we should simply check if $operations['edit'] is set :)

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham at Vardot commented
FileSize
fix_configure_link-2839334-7.patch670 bytes

Yes amateescu you are right

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham at Vardot commented
Status: Needs work » Needs review

  • amateescu committed 0ec6234 on 8.x-1.x authored by abu-zakham 
    Issue #2839334 by abu-zakham: EntityQueueListBuilder should check the...
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Title: EntityQueueListBuilder should check user permission before changing edit link title. » EntityQueueListBuilder should check the existence of the 'edit' link before changing its title
Status: Needs review » Fixed

Nice, committed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.