Current Status:
Basic Integration with CKEditor works. It supports all entity types and their corresponding view modes.

That being said, UI needs polishing and there's need for better error handling. If there's need for any feature, open a new issue and assign this issue as its parent.

Original Report:
I did a basic integration of the module with ckeditor. Right now all entity types, view modes etc. are not properly configured but it works for *node* entity type in *teaser* view mode.

Please provide some feedback on how this looks.

You need to add the 'E' button to ckeditor toolbar to enable this plugin.

I'll create sub-issues of this issue as required.

Comments

cs_shadow’s picture

Status: Active » Needs review

Link to PR: https://github.com/drupal-media/entity_embed/pull/22
EDIT: This PR has been merged.

cs_shadow’s picture

Status: Needs review » Needs work
cs_shadow’s picture

Issue summary: View changes
yched’s picture

Exciting module !

Shouldn't this leverage CKeditor widgets ?

dave reid’s picture

@yched: Thanks for checking out the module! Yes, I think we'll be covering it in #2280547: Add a preview of the entity selected in the form.

cs_shadow’s picture

Status: Needs work » Fixed

Marking this as fixed since we have a basic (and stable) integration with CKEditor.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.