Write functional tests for Views widget

working on this...

Freeing up the issue, please feel free to re-assign it if needed.

Please note that inside the patch uploaded in #2376643-4: Write functional tests for Upload widget there is a work-in-progress of this test, can be used as a starting point.

Working on this.

Initial patch for the starting point. Currently, it does not include the actual test case.

Changing status to Need review.

Fixed module names and permissions.

Updated patch. I've created a view and added its configuration file in entity_browser_test module.

Hoping it will come green this time :)

Improved documentation of the patch.

1. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +/**
   + * @file
   + * Contains \Drupal\entity_browser\Tests\EntityBrowserViewsWidgetWebTest.
   + */
   

   No need for this anymore. Look at #2304909: Relax requirement for @file when using OO Class or Interface per file

2. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +  public static $modules = [
   +    'system',
   +    'user',
   +    'node',
   +    'file',
   +    'field_ui',
   +    'ctools',
   +    'views',
   +    'views_ui',
   +    'entity_reference',
   +    'entity_browser_test',
   +  ];
   

   You can remove system, user, file, field_ui, views, entity_reference

   we only have to define what we need the dependencies are loaded automatically.

3. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +  /**
   +   * Setup Environment.
   +   */
   

   You can just {@inheritdoc} here.

4. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +    $this->user = $this->drupalCreateUser([
   +      'administer site configuration',
   +      'administer nodes',
   +      'administer content types',
   +      'administer node fields',
   +      'bypass node access',
   +      'administer views',
   +      'access content',
   +      'administer users',
   +      'access user profiles',
   +      'administer permissions',
   +      'administer entity browsers',
   +      'administer display modes',
   +      'administer node display',
   +      'administer node form display',
   

   We probably don't need all of these. Check which are not needed and remove.

5. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +      'title_label' => 'An example Custom Content type.',
   

   Not really needed.

6. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +      'cardinality' => '-1',
   

   Do we need this?

7. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +    // Create a new entity browser.
   +    $entity_browser = $this->createEntityBrowser();
   

   Instead of creating an entity browser like this you could export it in the configuration synchronization and place it in the test module.

8. +++ b/src/Tests/EntityBrowserViewsWidgetWebTest.php
   @@ -0,0 +1,173 @@
   +    // Add the permission to access to this entity_browser page to the user.
   +    $role = Role::load('authenticated');
   +    $role->grantPermission('access test_entity_browser entity browser pages');
   +    $role->save();
   

   If you export the browser you don't need this just add the permission when you create the user.

also if im not mistaken => 'checks if everything works as expected and entities are selected' We don't cover this part yet.

Because simpletest will be replaced with PHPUnit in 8.2.x should these tests instead leverage BrowserTestBase? Like the following:

http://cgit.drupalcode.org/video_embed_field/tree/tests/src/FunctionalJa...

Though I guess this would only be for 8.2.x branch? As the notes currently say:

"The main limitation of BrowserTestBase currently is that it cannot use JavaScript and AJAX. If your tests require that, you will need to use the old WebTestBase until JavaScript support is added to BrowserTestBase."

Based on the feedback in #17 and that the current patch doesn't actually test the View widget, I've written a minimalist patch using BrowserTestBase (per #18) that just tests the submit functionality of the widget. We can expand upon this later by testing more complex use cases, but this is nice because it scopes the test coverage to the View widget. If people like what I've done here I can roll a similar patch for #2376643: Write functional tests for Upload widget.