Problem/Motivation

The Entity module's DeleteAction class contains a @trigger_error() that fires when the class is discovered during plugin scanning, even when the class isn't actually used. This breaks compatibility with the ECA module which uses extended error handling during plugin discovery.

Steps to reproduce

  • Install Entity API module (v1.6.0)
  • Install ECA module
  • Enable ECA modules
  • Check logs for deprecation errors

Current Behavior
When ECA scans for available actions, it triggers the Entity module's deprecation warning:

ECA ran into error from third party in the context of "Collecting all available actions":
\Drupal\entity\Plugin\Action\DeleteAction has been deprecated in favor of \Drupal\Core\Action\Plugin\Action\DeleteAction. Use that instead.
Line 7 of /var/www/html/web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php

This happens because the @trigger_error() fires when the class is loaded during plugin discovery, not just when it's instantiated.

Proposed resolution

Move the deprecation notice from the class level to the constructor, so it only triggers when the class is actually used, not just discovered:

class DeleteAction extends CoreDeleteAction {
  /**
   * Constructor for DeleteAction.
   */
  public function __construct(array $configuration, $plugin_id, $plugin_definition) {
    @trigger_error('\Drupal\entity\Plugin\Action\DeleteAction has been deprecated in favor of \Drupal\Core\Action\Plugin\Action\DeleteAction. Use that instead.', E_USER_DEPRECATED);
    parent::__construct($configuration, $plugin_id, $plugin_definition);
  }
}

Patch
Attached is a patch that implements this fix. It follows Drupal's best practices for deprecation by continuing to show the warning when the class is actually used, while preventing errors during plugin discovery.

Impact and Importance
This issue affects any site using both Entity API and ECA modules. Currently, users must disable ECA to avoid the error, limiting functionality. The fix maintains the proper deprecation notice while allowing both modules to work together.

CommentFileSizeAuthor
#16 entity-deleteaction-deprecation-drupal11.patch2.03 KBaloknarwaria
entity-fix-deprecation.patch992 bytesdan_metille

Issue fork entity-3532309

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dan_metille created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented

Facing the same issue

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Active » Reviewed & tested by the community

Thanks, Dan, for reporting and patching.
Tested your patch, It is working well.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Deprecation notice from DeleteAction class causes errors in ECA module » Fix Deprecation notice from DeleteAction class causes errors in ECA module
bdunphy’s picture

bdunphy commented
Status: Reviewed & tested by the community » Needs work

Applied the patch against Entity API 8.x-1.6 and tested. The core DeleteAction expects 6 parameters not the 3 as stated in the patch file. A PHP error is thrown:

ArgumentCountError: Too few arguments to function Drupal\Core\Action\Plugin\Action\DeleteAction::construct(), 3 passed in /XXX/XXX/XXX/XXXX/web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php on line 24 and exactly 6 expected in *Drupal\Core\Action\Plugin\Action\DeleteAction->construct()* (line 53 of /XXX/XXX/XXX/XXX/web/core/lib/Drupal/Core/Action/Plugin/Action/DeleteAction.php)

akalam made their first commit to this issue’s fork.

akalam opened merge request !46

akalam’s picture

akalam commented
Status: Needs work » Needs review

I've created a MR fixing using the same arguments as in the core's Action Plugin

intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented
Status: Needs review » Reviewed & tested by the community

This appears to be working as the error has gone away

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

RTBC+1, this is something that we get quite a lot of support requests in ECA, an early merge and patch release would therefore be much appreciated.

mw4ll4c3’s picture

mw4ll4c3 commented

RTBC as well. A clean fix that only triggers the error when it's relevant.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
trickfun’s picture

trickfun commented

Patch works fine

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

The patch works fine
https://www.drupal.org/files/issues/2025-06-25/entity-fix-deprecation.patch

anaconda777’s picture

anaconda777 commented

Applied the patch but getting time to time wsod and

ArgumentCountError: Too few arguments to function Drupal\Core\Action\Plugin\Action\DeleteAction::__construct(), 3 passed in /var/www/html/site/web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php on line 24 and exactly 6 expected in Drupal\Core\Action\Plugin\Action\DeleteAction->__construct() (line 53 of /var/www/html/site/web/core/lib/Drupal/Core/Action/Plugin/Action/DeleteAction.php).

also got this ajax error while running update from the UI which I usually dont do...

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /update.php/start?id=1378&op=do_nojs&op=do
StatusText: OK
ResponseText: ECA ran into error from third party in the context of "Collecting all available actions": 
\Drupal\entity\Plugin\Action\DeleteAction has been deprecated in favor of \Drupal\Core\Action\Plugin\Action\DeleteAction. Use that instead.
Line 23 of /var/www/html/site/web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php
aloknarwaria’s picture

aloknarwaria commented
StatusFileSize
new entity-deleteaction-deprecation-drupal11.patch2.03 KB

Root Cause

web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php has a file-level @trigger_error(). ECA scans available action plugins during cache rebuild, so the class is loaded during discovery even when the deprecated action is not actually used.

Fix

Move the deprecation trigger from file/class load time into the constructor, and use Drupal 11’s parent constructor signature.

  • berdir committed 3031118c on 8.x-1.x authored by akalam 
    feat: #3532309 Fix Deprecation notice from DeleteAction class causes...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged. FWIW, not sure if ECA should do what it does. Errors, even pretty hard class/trait not found errors are ignored by core to deal with some edge cases of modules defining plugins using code from an optional module. This might conflict with that. But that's just a guess, haven't tried that.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

Just FYI, ECA doesn't crash with issues like this; it just reports an error in the logs. And, of course, only if the module is available, it's not an optional dependency.

Thanks for fixing this @berdir

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.