Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
@see title.
It would be nice to have this as an optional feature... especially for exportable entities.
Patch incoming.
Comment | File | Size | Author |
---|---|---|---|
#10 | entity-1437272-10.patch | 2.66 KB | daiwik.addweb |
| |||
#6 | 1437272.6.entity.admin-ui-description.patch | 2.6 KB | joachim |
#1 | entity-description.patch | 4 KB | fubhy |
Comments
Comment #1
fubhy CreditAttribution: fubhy commentedMaybe we need some entity property definitions for the description as well, currently this is only UI stuff in the patch.
Comment #3
fubhy CreditAttribution: fubhy commentedComment #4
fagoFirst line of comments may not be wrapped, but may exceed 80chars.
I don't think we need a helper function for reading the description key. I don't think it's often used in code and in the admin-ui it's more performant to read out the value out of the there existing entity info anyway.
This should default to no description key.
The CSS got already added via #attached, not?
Comment #5
joachim CreditAttribution: joachim commentedI don't think we need extra CSS here at all. Node module's content types list doesn't need any AFAICT.
Comment #6
joachim CreditAttribution: joachim commentedupdated patch.
I've taken out the CSS. I can't see any difference with it there at all.
Comment #7
fubhy CreditAttribution: fubhy commentedThe CSS is needed in case the overview is a tabledrag.
Comment #8
joachim CreditAttribution: joachim commentedAhhh.
But entity API's admin UI doesn't do tabledrags. (Yet -- I filed a feature request for that: #1659456: support for hierarchical entities.)
So currently, if an entity module turns this into a tabledrag it's surely up to that module to tweak the CSS as needed.
Comment #9
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 7 year old patch in #6 does not apply to the latest entity 7.x-1.x-dev.
Comment #10
daiwik.addweb CreditAttribution: daiwik.addweb at AddWeb Solution Pvt. Ltd. commented@Chris Matthews, Please review below-attached patch for latest entity 7.x-1.x-dev and kindly share your feedback on the same. thanks