Closed (fixed)
Project:
Encrypted fields user
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Dec 2015 at 14:08 UTC
Updated:
10 May 2016 at 08:22 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpifagor872571621git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
pifagor commentedFrom what I understand, this is not an error and they attended the contrib modules
Comment #4
pifagor commentedComment #5
gaja_daran commentedHi,
Manual Review:
1. Don't use the count function in for loop. It is called in each loop.
It is used in .install file
for ($count = 0; $count < count($array_settings); $count++) {Instead of above line
2. Remove following lines in encrypted_fields_user_uninstall function
drupal_uninstall_schema('encrypted_fields_user');
Drupal will handle this when module has disabled.
Comment #6
pifagor commentedFixed code despite previous comment. Thank you for your comments.
View changes
Comment #7
pifagor commentedYet any comments?
Comment #8
pifagor commentedComment #9
pifagor commentedComment #10
pifagor commentedComment #11
pifagor commented