Convert all WebTestBase to BrowserTestBase

1. rename from src/Tests/DynamicEntityReferenceTest.php
   rename to tests/src/Functional/DynamicEntityReferenceTest.php
   

   Should there be a namespace update here too?

2. +++ b/tests/src/Functional/DynamicEntityReferenceTest.php
   @@ -13,7 +13,7 @@ use Drupal\Core\Language\LanguageInterface;
   +use Drupal\simpletest\BrowserTestBase;
   
   @@ -22,8 +22,11 @@ use Symfony\Component\CssSelector\CssSelector;
   + * @preserveGlobalState disabled
   
   @@ -76,14 +79,14 @@ class DynamicEntityReferenceTest extends WebTestBase {
   +//    $this->assertSession()->fieldExistsByXPath(CssSelector::toXPath('select[name="default_value_input[field_foobar][0][target_type]"] > option[value=entity_test]'), 'entity_test');
   +//    $this->assertNoFieldByXPath(CssSelector::toXPath('select[name="default_value_input[field_foobar][0][target_type]"] > option[value=user]'), 'user');
   
   @@ -105,38 +108,38 @@ class DynamicEntityReferenceTest extends WebTestBase {
   +//    $this->assertSession()->fieldExistsByXPath(CssSelector::toXPath('select[name="default_value_input[field_foobar][0][target_type]"] > option[value=user]'), 'user');
   +//    $this->assertNoFieldByXPath(CssSelector::toXPath('select[name="default_value_input[field_foobar][0][target_type]"] > option[value=entity_test]'), 'entity_test');
   

   Still commented out?

I'm curious: what is blocking this issue, if anything? I don't see BrowserTestBase being used in core except in \Drupal\Tests\simpletest\Functional\BrowserTestBaseTest and can hardly find any contrib module using them. Is there any reason for that, besides awareness?

Excellent, thanks.

1. +++ b/tests/src/Functional/DynamicEntityReferenceBaseTest.php
   @@ -85,7 +85,7 @@ class DynamicEntityReferenceBaseTest extends WebTestBase {
   -    $this->assertTrue(strpos((string) $input['data-autocomplete-path'], $expected_autocomplete_path) !== FALSE);
   +    $this->assertTrue(strpos($input->getAttribute('data-autocomplete-path'), $expected_autocomplete_path) !== FALSE);
   
   @@ -234,10 +234,10 @@ class DynamicEntityReferenceBaseTest extends WebTestBase {
   -    $this->assertTrue(strpos((string) $input['data-autocomplete-path'], $expected_autocomplete_path) !== FALSE);
   +    $this->assertTrue(strpos($input->getAttribute('data-autocomplete-path'), $expected_autocomplete_path) !== FALSE);
   

   You could use $this->assertContains here

2. +++ b/tests/src/Functional/DynamicEntityReferenceBaseTest.php
   @@ -234,10 +234,10 @@ class DynamicEntityReferenceBaseTest extends WebTestBase {
        // Add some extra dynamic entity reference fields.
   -    $this->drupalPostAjaxForm(NULL, array(), array('dynamic_references_add_more' => t('Add another item')), NULL, array(), array(), 'entity-test-entity-test-form');
   +    $this->getSession()->getPage()->findButton('Add another item')->click();
   

   If this is an ajax form, how does it work without the JavascripTestBase?

3. +++ b/tests/src/Functional/DynamicEntityReferenceFieldDefaultValueTest.php
   @@ -107,8 +107,8 @@ class DynamicEntityReferenceFieldDefaultValueTest extends WebTestBase {
   +    $this->assertRaw('name="default_value_input[' . $field_name . '][0][target_id]" value="' . $referenced_node->getTitle() . ' (' . $referenced_node->id() . ')');
   

   there is responseContains

Feel free to fix those points after commit