Follow-up to #2469609: Convert all WebTestBase to BrowserTestBase

CommentFileSizeAuthor
#6 remove_the_deprecated-2751409-6.patch47.99 KBjibran
#6 interdiff.txt31.02 KBjibran
#4 remove_the_deprecated-2751409-3.patch41.86 KBjibran
#4 interdiff.txt1.11 KBjibran
#2 remove_the_deprecated-2751409-2.patch41.45 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Active » Needs review
FileSize
remove_the_deprecated-2751409-2.patch41.45 KB

Status: Needs review » Needs work

The last submitted patch, 2: remove_the_deprecated-2751409-2.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.11 KB
remove_the_deprecated-2751409-3.patch41.86 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented 
  1. +++ b/tests/src/Functional/DynamicEntityReferenceBaseTest.php
@@ -101,14 +101,14 @@ class DynamicEntityReferenceBaseTest extends BrowserTestBase {
-    $this->assertEqual(1, count($entities), 'Entity was saved');
+    $this->assertEquals(count($entities), 1, 'Entity was saved');
...
-    $this->assertEqual(count($entity->dynamic_references), 1, 'One item in field');
-    $this->assertEqual($entity->dynamic_references[0]->entity->label(), 'item1');
+    $this->assertEquals(count($entity->dynamic_references), 1, 'One item in field');
+    $this->assertEquals($entity->dynamic_references[0]->entity->label(), 'item1');

    Could be assertCount 

  2. +++ b/tests/src/Functional/DynamicEntityReferenceBaseTest.php
@@ -101,14 +101,14 @@ class DynamicEntityReferenceBaseTest extends BrowserTestBase {
-    $this->assertText('Barfoo');
-    $this->assertText('item1');
+    $this->assertSession()->pageTextContains('Barfoo');

    In those cases you store store $assert = $this->assertSession()

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
FileSize
interdiff.txt31.02 KB
remove_the_deprecated-2751409-6.patch47.99 KB

Thanks for the review. Fixed #5.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Cool, thank you @jibran!

  • jibran committed 1aa2884 on 8.x-1.x 
    Issue #2751409 by jibran, dawehner: Remove the deprecated function calls...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review. Committed and pushed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.