Closed (fixed)
Project:
Dynamic Entity Reference
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2015 at 03:22 UTC
Updated:
7 Apr 2015 at 02:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jibranThis also includes the fixes from #2405469: FileFormatterBase should extend EntityReferenceFormatterBase
Comment #2
larowlanLove that this is a unit-test, so will be quick. Brilliant work!
Just one question:
Does this make the test fragile if further css changes in core remove some of these divs?
Comment #3
jibranI practically copied
EntityReferenceFormatterTestbut let me see perhaps we can use some kind of theme function here. IMO this is html so fragile is better.Comment #4
jibranNo We can't use theme function here. The only way to test it is to test the raw markup and we have no other way then this.
Comment #6
larowlanok
Comment #7
jibranThanks.