Problem/Motivation

After #2346273: Allow user to select bundles per entity type on field settings page we have problem same as #2370703: ER's "autocreate" feature is mostly broken (and untested).
1) formatters don't output anything in preview mode
2) widgets lose their data when returning to the node edit form

Proposed resolution

Add tests and fix the problem

Remaining tasks

Create a patch

User interface changes

None

API changes

N/A

CommentFileSizeAuthor
#20 der_s_autocreate-2389605-20.patch3.87 KBjibran
#15 2389605-der-autocreate-15.patch6.02 KBjibran
#15 interdiff.txt1.39 KBjibran
#7 2389605-7-der-autocreate.patch5.57 KBjibran
#7 interdiff.txt2.04 KBjibran
#3 2389605-der-autocreate-3.patch4.71 KBjibran
#3 interdiff.txt2.24 KBjibran
#1 2389605-der-autocreate-1.patch4.37 KBjibran

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 2389605-der-autocreate-1.patch4.37 KB

Here is the test patch.

Status: Needs review » Needs work

The last submitted patch, 1: 2389605-der-autocreate-1.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: Unassigned » larowlan
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.24 KB
new 2389605-der-autocreate-3.patch4.71 KB

Added new asserts.

Status: Needs review » Needs work

The last submitted patch, 3: 2389605-der-autocreate-3.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Hi Jibran
Thanks for this.
What do you need from me?

Lee

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I have no idea how to fix these fails.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
Related issues: +#2374019: Cleanup the use of custom item properties in EntityReferenceFormatterBase
StatusFileSize
new interdiff.txt2.04 KB
new 2389605-7-der-autocreate.patch5.57 KB

Also added #2374019: Cleanup the use of custom item properties in EntityReferenceFormatterBase fixes.

Status: Needs review » Needs work

The last submitted patch, 7: 2389605-7-der-autocreate.patch, failed testing.

Status: Needs work » Needs review

jibran queued 7: 2389605-7-der-autocreate.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2389605-7-der-autocreate.patch, failed testing.

Status: Needs work » Needs review

jibran queued 7: 2389605-7-der-autocreate.patch for re-testing.

jibran queued 3: 2389605-der-autocreate-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2389605-7-der-autocreate.patch, failed testing.

The last submitted patch, 3: 2389605-der-autocreate-3.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.39 KB
new 2389605-der-autocreate-15.patch6.02 KB

Removed #2374019: Cleanup the use of custom item properties in EntityReferenceFormatterBase fix to test.

Status: Needs review » Needs work

The last submitted patch, 15: 2389605-der-autocreate-15.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

we have the same problem as #2404331: Can't serialise an entity with an entity reference to an unsaved entity (remove EntityReferenceItem::$NEW_MARKER in favour of a validation constraint). I'll create an issue for DER.

Status: Needs work » Needs review

jibran queued 15: 2389605-der-autocreate-15.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 15: 2389605-der-autocreate-15.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new der_s_autocreate-2389605-20.patch3.87 KB

Reroll.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Wow - test only now!

  • jibran committed b67f42f on 8.x-1.x 
    Issue #2389605 by jibran: DER's "autocreate" feature is mostly broken (...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: larowlan » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks for the review. Committed and pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.