Language Render Problem

I'm getting the same error with the Drupal Distribution. Error reference for persons searching:

PHP Fatal error:  Declaration of Drupal\ds\Plugin\views\Entity\Render\TranslationLanguageRenderer::getLangcode(Drupal\views\ResultRow $row) must be compatible with Drupal\ds\Plugin\views\Entity\Render\DefaultLanguageRenderer::getLangcode(Drupal\views\ResultRow $row, $relationship = NULL) in /modules/ds/src/Plugin/views/Entity/Render/TranslationLanguageRenderer.php on line 11

Seems the issue is that an overridden method does not take the same parameters as the parent method.

Solution: Edit modules/ds/src/Plugin/views/Entity/Render/TranslationLanguageRenderer.php and change the function declaration:

public function getLangcode(ResultRow $row) {

TO

public function getLangcode(ResultRow $row, $relationship = NULL) {

It needs to have the $relationship argument even if it's not being used.

It's maybe better to change function declaration of DefaultLanguageRenderer since EntityTranslationRendererBase does not include $relationship parameter

This seems to be already fixed in the dev branch.

https://cgit.drupalcode.org/ds/commit/?h=8.x-3.x&id=7a1d9f8e25c1796ebc3f...

Hello,
thanks for the patch, works like a charm for me.

Thanks !