Allow Users To Set myqldump Arguments In drushrc.php (for drush sql dump)

Here is the review:

the patch has 3 chunks:
1. wholy commented out block in example.drushrc.php with thorough explanations. It is in the right spot of the file.

2. again in the right spot of sql.drush.inc (after the ommit tables stuff - like in 1.) there is a new var holding the options and ensuring that if nothing given from drushrc the defaults will hold

+

+ // Pass the necessary arguments from drushrc.php. If there are no arguments,

+ // use the default --single-transaction --opt -Q

+ $mysqldump_arguments = drush_get_option('mysqldump-arguments');

+ if (!$mysqldump_arguments) {

+ $mysqldump_arguments = '--single-transaction --opt -Q';

+ }

+

3. the actual usage of the option string -

- $extra = ' --single-transaction --opt -Q' . _drush_sql_get_credentials($db_spec);
+ $extra = ' ' . $mysqldump_arguments . _drush_sql_get_credentials($db_spec);

patch is ok - lets commit it .

PS. God bless the user "sun" for the dreditor greasemonkey helper - especially the hide/show buttons - with which I reviewed this patch.

here is the sql cli patch that pends:
http://drupal.org/node/570890

actually I would like to slightly change the last patch and incorporate the sql cli stuff in in too.

This is going to be called - the "sql options override patch"

please review this

Waiting for #460924: Remote site aliases for Drush (Proposal and implementation) to land before messing with related code. Should happen soon. We should be able to get this in easily before next release.

perhaps greg has an opinion here.

Yep. I'll comment when I have more time, but I think this will need some modification to play nice with #671906: mysql credentials leak in drush sqlc.

Okay, I took a look at this today. I don't think there's any reason to tie this issue to #671906: mysql credentials leak in drush sqlc any more.

I don't think there is any value to grouping these options in a multi-dimensional array. I would instead recommend something like this:

# $options['mysql-cli'] = '-A';
# $options['mysql-query'] = '';
# $options['mysql-dump'] = '--single-transaction --opt -Q'
# // To create VCS/diff friendly dumps:
# $options['mysql-dump'] = '--single-transaction --opt -Q --skip-extended-insert '

Did I get the args right for mysql dump?

Anyway, this would allow people to use the slower VCS/diff-friendly dumps on sql-dump, and use faster unordered dumps for sql-sync:

$options['command-specific']['sql-dump'] = array( 'mysql-dump' => '...' );

(n.b. 'sql-dump' would be 'sql dump' prior to completion of #550522: Change white spaces in commands by another symbol.)

The other advantage of going this way is that you can then make the code read more like this:

$command .= drush_get_option('mysql-cli', '-A') . ' ' . _drush_sql_get_credentials();

Extra spaces do not hurt exec, so put the spaces in the code -- do not require them in the options.

My last #4 patch's idea was to give the max flexibility. I no longer remember its anatomy and so - have fun and do what you please with my patch code. Hope it helps.

Yes, it helps.

Anyway, I'll put this back on my plate for later processing, unless Brian comes back around and picks it up.

Bump... will try to get this in for the next release, but I imagine that is optional.

Tag for drush-3.0

Just a note that while I think this issue should be done eventually,, the needs of the O.P. are already met by the existing flag --ordered-dump, so I've been doing more important things and probably won't get to this until sometime after #759906: Update core without moving core files out of the way..

Subscribing.

See also #1283978: Parameter --skip-add-locks in mysql dump and #898924: Allow users to set arguments for mysql command in sql-sync and others.

Another use case at #1672894: sql-sync support the --where condition

The use case in #17 assumes a unique --where is sent on each table (implying a separate mysqldump command for each partial table). This would make a single command line solution quite complex.

We should convert the drush sql-dump command to use strict options (Drush 6 only); this would allow multiple 'where' options to be used at the same time, just like mysql dump. However, I must acknowledge that this is still not as good of a solution as #1672894, as it is difficult to represent multiple 'where' conditions in an alias record this way. Perhaps we should be having this discussion in the other incident.

This issue was marked closed (won't fix) because Drush has moved to Github.

If this feature is still desired, you may copy it to our Github project. For best results, create a Pull Request that has been updated for the master branch. Post a link here to the PR, and please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.

Copied to Github at https://github.com/drush-ops/drush/issues/178