Error message in installer mentions possibly wrong username, etc. but not port

Could you go over the messages and clean up the wording a little bit? Sometimes we use 'database something' (eg. 'database port'). Other times we use just 'something' (eg. 'port').

This issue is about the port notices which are rather consistent of what there are. Such a consistency patch can be rolled separately. (I am not 100% we need that, if we talk about database server do we need to stress that the username and password is for the database server? but, separate issue)

The added code needs to be consistent with itself. I think 'port' is good in these contexts.

This is still valid. Relevant code: http://drupalcode.org/project/drupal.git/blob/HEAD:/includes/install.inc...

Tagging with usability, because of recent efforts to reduce wordiness of messages and help text. Maybe the text is good as is, in which case this is won't fix.

Adding tag

tstoeckler,

Can you add the patch? I can't see the reference.

@NROTC_Webmaster: Sorry, I don't get what you mean. Which patch?

I was talking about the link in #5 but I'm guessing you were actually referring to the file in core.

Why don't we just mention possible wrong port number along with possible wrong host name in the same sentence? It may sound like this:

* Have you entered the correct database name?
* Have you entered the correct username and password?
* Have you entered the correct database hostname and port number?

Patch is attached (made on 8.8-dev branch).

Looking forward to your thoughts.

Submitting new patch since the previous one has failed to apply.

+++ b/core/lib/Drupal/Core/Database/Driver/sqlite/Install/Tasks.php
@@ -97,7 +97,7 @@ protected function connect() {
-        $this->fail(t('Failed to connect to your database server. The server reports the following message: %error.<ul><li>Is the database server running?</li><li>Does the database exist, and have you entered the correct database name?</li><li>Have you entered the correct username and password?</li><li>Have you entered the correct database hostname?</li></ul>', ['%error' => $e->getMessage()]));
+        $this->fail(t('Failed to connect to your database server. The server reports the following message: %error.<ul><li>Is the database server running?</li><li>Does the database exist, and have you entered the correct database name?</li><li>Have you entered the correct username and password?</li><li>Have you entered the correct database hostname and port number?</li></ul>', ['%error' => $e->getMessage()]));

sqlite does not have the concept of username/password, port number and hostname. the fail messages here should mostly be about filesystem permissions and the path to the database file, I think.

I rewrote messages for sqlite. Replaced "database server and database" with "database engine and database file". If these changes need to be discussed, I will remove sqlite from this patch and create a separate issue for adjusting sqlite install messages.

Also, this issue might be resolved by resolving https://www.drupal.org/project/drupal/issues/3050161

+1 from me!

The patch in #19 looked good except for minor grammar hiccups with the SQLite message. I have added a new patch to fix these.

I changed the branch to 8.8.x, because all active development should happen there now that 8.7.x is released.

Thank you @Gogowitsch. Your adjustment is fine for me.
Looking forward for more reviewers

Seems that this is ready to go to Core maintainers.

#3055648: Frequent random fail in \Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTest

Rerun tests

All tests passed.

13 years!

Committed 747bd48 and pushed to 8.8.x. Thanks!