#517814: File API Stream Wrapper Conversion made changes to the logic of the code without reguard to the code that was there and changed its function.

CommentFileSizeAuthor
#22 577398-fapi-fix.patch3.87 KBboombatower
#20 577398-fapi-fix.patch3.87 KBboombatower
#18 577398-fapi-fix.patch3.87 KBboombatower
#16 577398-fapi-fix.patch3.66 KBboombatower
#14 577398-fapi-fix.patch3.61 KBboombatower
#12 577398-fapi-fix.patch3.61 KBboombatower
#10 577398-fapi-fix.patch3.61 KBboombatower
#8 577398-fapi-fix.patch3.61 KBboombatower
#6 577398-fapi-fix.patch3.62 KBboombatower
#3 577398-fapi-fix.patch3.2 KBboombatower
#2 577398-fapi-fix.patch2.31 KBboombatower
#1 577398-fapi-fix.patch2.84 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 577398-fapi-fix.patch2.84 KB
boombatower’s picture

boombatower commented
StatusFileSize
new 577398-fapi-fix.patch2.31 KB

Extra stuff form other patch.

boombatower’s picture

boombatower commented
StatusFileSize
new 577398-fapi-fix.patch3.2 KB

Need both sets of changes.

Status: Needs review » Needs work

The last submitted patch failed testing.

chx’s picture

chx commented
Title: FAPI broke SimpleTest temporary file handling » File API broke SimpleTest temporary file handling

Ah yes. There are more problems here, I think the error_log wants to go to a wrong directory too and it causes problems.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.62 KB

Re-rolled.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.61 KB

Mail system variable changed names which fixed all the tests.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.61 KB

Pass locally. Any thoughts?

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.61 KB

...

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.61 KB
c960657’s picture

c960657 commented
Status: Needs review » Needs work 
+++ modules/simpletest/drupal_web_test_case.php	21 Oct 2009 04:32:06 -0000
@@ -1046,8 +1046,14 @@
+    // Create the directories
+    $directory = file_directory_path('public');
     file_prepare_directory($directory, FILE_CREATE_DIRECTORY | FILE_MODIFY_PERMISSIONS);
+    file_prepare_directory($private_files_directory, FILE_CREATE_DIRECTORY);

At this point file_directory_path('public') still returns the files directory of the site running the test, and that already exists. I assume you meant to prepare $public_files_directory instead? The public directory is created in the next line, because the private directory is a subdirectory of the public.

Slightly outside the scope of this issue: We should probably use file_directory_path('public') instead of file_directory_path() when initializing $this->originalFileDirectory earlier in setUp() to make sure that $public_files_directory points to a public directory.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.66 KB

Updated.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.87 KB

How about we fix that line :)

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.87 KB

Gotz me.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 577398-fapi-fix.patch3.87 KB

Lets try this on PIFR 2.x and get some assertion messages!

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Good one! It's very easy to see that the current is broken, that preg matched simpletest123456 while creating simpletest/123456 dirs.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Active

Committed to HEAD. Now. The real problem here is actually that we have no test coverage for this bit of code, or else the conversion to stream wrappers would never have broken it in the first place. Is it possible to add test coverage here for SimpleTest's file handling, or is that a bit too meta for it to handle?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Needs tests

.

boombatower’s picture

boombatower commented
Title: File API broke SimpleTest temporary file handling » Ensure test coverage of simpletest temporary file handling
Version: 7.x-dev » 8.x-dev
Category: bug » task
boombatower’s picture

boombatower commented
Assigned: boombatower » Unassigned

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • webchick committed e14a263 on 8.3.x 
    #577398 by boombatower: Fix SimpleTest temporary file handling, post-...

  • webchick committed e14a263 on 8.3.x 
    #577398 by boombatower: Fix SimpleTest temporary file handling, post-...

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • webchick committed e14a263 on 8.4.x 
    #577398 by boombatower: Fix SimpleTest temporary file handling, post-...

  • webchick committed e14a263 on 8.4.x 
    #577398 by boombatower: Fix SimpleTest temporary file handling, post-...

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • webchick committed e14a263 on 9.1.x 
    #577398 by boombatower: Fix SimpleTest temporary file handling, post-...

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.