After landing the landmark fix for #3583486, the default_admin theme will lose Gin-specific CSS classes that provide custom styling for the top bar and breadcrumbs.
The MR !15389 adjusts top-bar--gin.html.twig to use <aside> with an aria-label for the landmark. If this change (or a similar one) modifies or removes the Gin-specific twig template, the following CSS classes will no longer be applied:
gin--navigation-top-bar— used incss/layout/top-bar.cssfor:- Background color (
var(--admin-color-bg-surface)) - Border styling (
var(--admin-color-border-soft)) - High contrast mode handling
- Backdrop blur effect
- Layout (flex display, gap, padding)
- Dropdown menu styling
- Background color (
gin-breadcrumb— used incss/components/breadcrumb.cssfor:- Breadcrumb text styling
- Link colors and hover states
- Separator styling
- Spacing and layout
Proposed Solution
Step 1: Audit current CSS dependencies
Review all selectors in core/themes/default_admin/css/ that target:
.gin--navigation-top-bar.gin-breadcrumb.gin-breadcrumb__*(list, item, link, text)
Step 2: Migrate CSS to work without twig overrides
Either:
- Option A: Update the CSS selectors to target the new markup (e.g.,
<aside>with standard classes) - Option B: Ensure the new twig template still applies equivalent classes
Step 3: Preserve visual regression test baselines
After migrating CSS, update VRT baselines to reflect the new markup structure while maintaining the same visual appearance.
Related Issues
- #3583486 — Adjust default_admin's top bar to use the landmark used with the navigation module
- #3540607 — Upstream Gin issue for color handling
Files to Review
core/themes/default_admin/templates/navigation/top-bar--gin.html.twigcore/themes/default_admin/templates/navigation/breadcrumb.html.twigcore/themes/default_admin/templates/page/page.html.twigcore/themes/default_admin/css/layout/top-bar.csscore/themes/default_admin/css/layout/top-bar.pcss.csscore/themes/default_admin/css/components/breadcrumb.csscore/themes/default_admin/css/components/breadcrumb.pcss.css
Patch
See attached color-migration.patch for the proposed changes:
- top-bar.pcss.css: Adds
.top-barselectors alongside.gin--navigation-top-bar - page.html.twig: Updates
gin--navigation-top-bar--offsettotop-bar--offset - breadcrumb.pcss.css: Adds
nav[aria-labelledby="system-breadcrumb"]selectors for standard breadcrumb markup
Acceptance Criteria
- Todo: All
gin--navigation-top-barstyling works without the Gin-specific twig template - Todo: All
gin-breadcrumbstyling works without the Gin-specific twig template - Todo: Visual appearance matches current state (VRT passes)
- Todo: High contrast mode still works correctly
- Todo: Landmark semantics are correct (
<aside>with appropriatearia-label)
AI Disclaimier: Yes, AI was used in the creation of this issue.
Issue fork drupal-3611446
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3611446-migrate-gin-css
compare
- main
changes, plain diff MR !16340
Comments
Comment #2
mgiffordComment #4
jurgenhaasThe unique requirements from this issue have been transferred to canonical implementation issue #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme.
That plan now explicitly covers top-bar and breadcrumb selectors coupled to markup; synchronized Twig/PHP, JavaScript, PCSS, and compiled-CSS changes; landmark semantics and accessible naming; breadcrumb semantics, labeling, keyboard and focus behavior; high-contrast support; and VRT without unintended visual changes.
MR!16340 remains a reference inventory and should not be cherry-picked wholesale. Please preserve credit where its investigation or implementation informs the replacement.