This is copied over from @rkoller's Gin issue #3541719: Adjust the top bar to the landmark used with the navigation module, and verified by me, Mike, Jurgen, and Bernardo
Problem/Motivation
#3452724: Navigation side bar and top bar should have appropriate aria labels solidifies the landmarks used with the navigation module. With the MR applied to core and using Claro you have two landmarks, Administrative sidebar navigation for the navigation sidebar and Administrative top bar complementary for the top bar.

While in Gin you only have the landmark for the navigation sidebar, the one for the top bar is missing:

Steps to reproduce
- apply the MR in #3452724: Navigation side bar and top bar should have appropriate aria labels to core
- go to a node edit form with gin as the active admin theme
- activate your screenreader of choice (in for example voice over activate the rotor)
Proposed resolution
i would align with a few details in claro:
- change the wrapping element from a div to an aside to make it more semantic
- add a visually hidden h3 and use that h3 as the label for the aside
the naming of both landmarks for the navigation sidebar and top bar might change at a later point, see #3539715: Review navigation landmark naming
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2026-04-08 at 10.03.00 PM.png | 188.37 KB | bernardm28 |
| #5 | Screenshot 2026-04-08 at 10.01.58 PM.png | 25.46 KB | bernardm28 |
| #3 | Screenshot 2026-04-07 at 12.07.18 PM.png | 265.12 KB | bernardm28 |
Issue fork drupal-3583486
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mgiffordGreat to see this moved over.
Comment #3
bernardm28 commentedLooks like just removing top-bar--gin.html.twig would create some chaos with dark mode.
Comment #5
bernardm28 commentedThe image above wasn't the best example because I was confusing the primary aside.
However, here is a better one.
Without the gin toolbar override. In other words, what happens if we delete that file.

Removing the gin toolbar creates color contrast issues with the submenus
With gin override.
That said, if all we need for the MVP of this issue is to move a step forward. The PR above is similar to the one on the gin project and provides us with a more consistent experience.
Comment #6
bernardm28 commentedComment #7
bernardm28 commentedI should add the main color issue lies on the css class
gin--navigation-top-barmissing if we remove the twig override.Other than that DDEV VRT fails because removing the file also gets rid of the gin_breadcrumbs so idk if we are ok losing those.
If we merge the PR above then we don't have to take care of those issues yet and then most of the playrights test pass and the only that failed seem to be a false positive.
Comment #8
mgiffordI suspect that the color issue should be addressed elsewhere. This should be focused on adding back in the landmarks.
I'd love to the landmark brought into the theme.
Comment #9
kentr commentedRE #7:
Creating color contrast issues and / or losing breadcrumbs would be regressions.
Some code for dark mode will be needed regardless. Personally, I think that should remain in the theme.
Comment #10
smustgrave commentedIf we can move the color issue to a separate issue?
Comment #11
kentr commentedComment #12
mgiffordI added a follow-up issue to address the color issues that @bernardm28 mentioned in #7
https://www.drupal.org/project/drupal/issues/3611446
@smustgrave the patch associated with this issue doesn't have any color changes in it. We should be able to assess these separately now.
Comment #13
mgiffordComment #14
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #15
kentr commentedI think it needs a rebase.
Comment #16
kentr commentedI'll rebase it.
Comment #17
kentr commentedRebased.
To me, the IS needs updating because it references Gin and the screenshot of the problem doesn't match what I see with a fresh install on
main(for example, there are no "Edit", "Preview", "Delete" buttons).Comment #19
jurgenhaasIssue fork got rebased.
Comment #20
kentr commentedI think the name of the template file changed in
maintotop-bar--default-admin.html.twig.Alternate STR:
/user/1/edit.