Problem/Motivation

While removing deprecation this keeps popping up for people

Fail      Other      MigrationTest.php   36 Drupal\Tests\migrate\Unit\Migration
    Drupal\Tests\migrate\Unit\MigrationTest::testMigrationDependenciesInConstructor
    with data set "invalid key" (array(array()))
    This test did not perform any assertions
    
    /builds/issue/drupal-3443198/core/tests/Drupal/Tests/Listeners/DrupalListener.php:62
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/Framework/TestResult.php:453
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/Framework/TestResult.php:981
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/TextUI/Command.php:146
    /builds/issue/drupal-3443198/vendor/phpunit/phpunit/src/TextUI/Command.php:99

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3443255

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

quietone’s picture

quietone commented
Title: Random migration unit test failure » [random test failure] MigrationTest::testMigrationDependenciesInConstructor
Parent issue: » #3401720: [random test fail] TimestampFormatterWithTimeDiffViewsTest::testTimestampFormatterWithTimeDiff

This should be added to the meta for random failures so we can keep track of it.

There are special issue titles used in Drupal core, and there is one for random test failures. And there are guidelines (that need updating) for handling random test failures.

mikelutz made their first commit to this issue’s fork.

mikelutz opened merge request !7778

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs review
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

At https://git.drupalcode.org/project/drupal/-/commit/166f3a39e466c2870dcb6... we removed a check and deprecation, but we should have replaced the deprecation with an exception. We removed the deprecation check from the test which left no assertions, but it should have been turned into an exception check.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks for fixing this!

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Priority: Normal » Major
Related issues: +#3439369: Remove deprecated code in migration system

  • catch committed 6148f314 on 11.x 
    Issue #3443255 by mikelutz: [random test failure] MigrationTest::...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !7778

  • catch committed 6148f314 on 11.0.x 
    Issue #3443255 by mikelutz: [random test failure] MigrationTest::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.