Problem/Motivation

There is deprecated code on 11.x

Steps to reproduce

Proposed resolution

Remove deprecated code scheduled to be removed in Drupal 11 from

  • core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
  • core/modules/migrate/src/Plugin/MigrationInterface.php
  • core/modules/migrate/src/Plugin/Migration.php

Remaining tasks

MR
review
commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3439369

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

fromme made their first commit to this issue’s fork.

fromme opened merge request !7379

fromme’s picture

fromme commented
Status: Active » Needs review

I removed deprecated code according:
- https://www.drupal.org/node/3282894
- https://www.drupal.org/node/3277306

Opened MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Appears to have phpcs error.

fromme’s picture

fromme commented
Status: Needs work » Needs review

Updated tests.
Looks like all tests passed successfully.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems to have one more in migrate module for Migrate.php

Searched for deprecation and drupal:11.0

fromme’s picture

fromme commented
Status: Needs work » Needs review

Removed deprecated code according https://www.drupal.org/node/3266691

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks, believe this is good now

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

I've added some comments to the MR - one of the deprecation removal is a bit more complex than just removing code.

pradhumanjain2311 made their first commit to this issue’s fork.

fromme’s picture

fromme commented
Status: Needs work » Needs review

Done

quietone’s picture

quietone commented
Title: Removed deprecated code in migration system » Remove deprecated code in migration system
quietone’s picture

quietone commented
Issue tags: +Major version only
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

The $expand deprecation removal looks good now. I think though that we need to add a CR here and properly deprecate passing in the $expand parameter. It's the deprecation dance that takes two majors...

quietone’s picture

quietone commented
Status: Needs work » Needs review

Added the CR and updated the deprecation message.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

CR reads straight to the point.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 166f3a3 and pushed to 11.x. Thanks!

  • alexpott committed 166f3a39 on 11.x 
    Issue #3439369 by fromme, quietone, pradhumanjain2311, smustgrave,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.