Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 Apr 2024 at 13:06 UTC
Updated:
8 May 2024 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
smustgrave commentedComment #4
smustgrave commentedNot sure what's going on with that migration test.
Comment #6
andypostAdded further clean-up of BC as it's unused now
Comment #7
andypostRemoval of
PhpassHashedPasswordBase::countLog2and related needs review for BC as it was not deprecated in the base classComment #8
smustgrave commentedTests are green but also don’t know the policy around protected functions.
Comment #9
catchWe should add an MR to deprecate those things in 10.3 here I think, then we can commit the deprecation and removal in one go - they're just leftovers so it won't make sense to use them with the other changes happening here, but better to keep things in sync.
Comment #11
smustgrave commentedAdded simple CR and 10.3.x branch that deprecates that function.
Comment #12
catchIt probably needs deprecated property trait for the deprecated properties too?
Comment #13
smustgrave commentedMean like this?
Comment #14
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #15
smustgrave commentedThink the bot is confused because I got a 10.3 MR up also
Comment #16
smustgrave commentedSelf review but looking at others believe got this right
Failure appears to be related to #3443248: Can't log out on translated site in tests - causes issues for 10.3 umami test
Comment #17
andypostRemoved unrelated file and the property is not a service, so properly deprecated it
Comment #18
andypostfixed cs
Comment #19
andypost10.3 is green
Comment #20
smustgrave commentedBased on the slack thread believe this one is good to go.
Comment #23
catchLooks good now. Committed/pushed to 11.x and 10.3.x respectively, thanks!