Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3443198-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3443198

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

Assigned: Unassigned » smustgrave

smustgrave’s picture

Status: Active » Needs work

Not sure what's going on with that migration test.

andypost made their first commit to this issue’s fork.

andypost’s picture

Added further clean-up of BC as it's unused now

andypost’s picture

Status: Needs work » Needs review

Removal of PhpassHashedPasswordBase::countLog2 and related needs review for BC as it was not deprecated in the base class

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Tests are green but also don’t know the policy around protected functions.

catch’s picture

Status: Reviewed & tested by the community » Needs review

We should add an MR to deprecate those things in 10.3 here I think, then we can commit the deprecation and removal in one go - they're just leftovers so it won't make sense to use them with the other changes happening here, but better to keep things in sync.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Added simple CR and 10.3.x branch that deprecates that function.

catch’s picture

Status: Reviewed & tested by the community » Needs review

It probably needs deprecated property trait for the deprecated properties too?

smustgrave’s picture

Mean like this?

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

Status: Needs work » Needs review
Issue tags: +no-needs-review-bot

Think the bot is confused because I got a 10.3 MR up also

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Self review but looking at others believe got this right

Failure appears to be related to #3443248: Can't log out on translated site in tests - causes issues for 10.3 umami test

andypost’s picture

Status: Reviewed & tested by the community » Needs review

Removed unrelated file and the property is not a service, so properly deprecated it

andypost’s picture

fixed cs

andypost’s picture

10.3 is green

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Based on the slack thread believe this one is good to go.

  • catch committed 9aa8d39c on 11.x
    Issue #3443198 by andypost, smustgrave, catch: Remove deprecated code...

  • catch committed f80fbb16 on 10.3.x
    Issue #3443198 by andypost, smustgrave, catch: Remove deprecated code...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks good now. Committed/pushed to 11.x and 10.3.x respectively, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.