Problem/Motivation

Queuing/Queueing is a very fun word, and has two correct spellings, neither of which is associated with typical US/UK conventions, they're just, both correct (i.e. there's no existing spelling standard that dictates which spelling we should be using in Drupal).

Should we set a "correct spelling" for the Drupal ecosystem, in cspell/dictionary.txt?

https://english.stackexchange.com/questions/60852/queueing-or-queuing

Proposed resolution

I strongly recommend "queueing" because, oh my god, five consecutive vowels is definitely the correct answer.

1) Change flagwords in cspell.json to include queuing

    "flagWords": [
      "e-mail",
      "grey",
      "hte",
      "ist",
      "please",
      "queuing"
    ],

2) yarn run -s spellcheck:core --no-must-find-files --no-progress

3) Fix any occurrences found.

Remaining tasks

Drupal is to use queueing.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#23 Screenshot 2024-02-11 at 11.12.14.png39.7 KBbramdriesen
#6 3364292-6.patch1.52 KB_utsavsharma
#6 interdiff_1-6.txt1.52 KB_utsavsharma

Issue fork drupal-3364292

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alison created an issue. See original summary.

alison’s picture

alison
she/her
commented
Issue summary: View changes
cilefen’s picture

cilefen commented

+1 for "queueing", same reasons.

quietone’s picture

quietone commented
Title: dictionary: queueing vs. queuing » spelling queueing vs. queuing
Issue tags: +cspell error
Related issues: +#3122088: [Meta] Remove spelling errors from dictionary.txt and fix them
quietone’s picture

quietone commented
Parent issue: » #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them
Related issues: -#3122088: [Meta] Remove spelling errors from dictionary.txt and fix them

That was meant to be the parent, not related

_utsavsharma’s picture

_utsavsharma commented
Status: Active » Needs review
StatusFileSize
new interdiff_1-6.txt1.52 KB
new 3364292-6.patch1.52 KB

Added queueing to dictionary.txt and changed its occurrence in the remaining files.

quietone’s picture

quietone commented
Component: javascript » other
Issue summary: View changes
Status: Needs review » Active

@_utsavsharma, thank you for your interest in spelling issue. Before uploading a patch it is good practice to make sure that it applies locally. Also, spelling issues often require the rebuilding of the dictionary so I recommend reading the parent issue of this one. Cheers!

I am setting this to active because we need to decide which spelling or spellings we want to use in Drupal before patching. Also, this patch is adding a word to the Drupal dictionary which already existing in the en_us dictionary.

pragati_kanade’s picture

pragati_kanade commented
Assigned: Unassigned » pragati_kanade
Status: Active » Reviewed & tested by the community

Above Patch looks good to me. All "queuing" replace with recommended spell "queueing".

pragati_kanade’s picture

pragati_kanade commented
Assigned: pragati_kanade » Unassigned
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

quietone’s picture

quietone commented
Status: Needs work » Active

@pragati_kanade, the previous comment set this issue to Active because there has not really been enough discussion on the choice of spelling.

dww’s picture

dww
we/he/they
commented

+1 to "queueing" as the "correct" spelling, even though there's some indication that that's the "British" way of spelling it, while the version with 1 'e' is more "American".

British

https://www.oed.com/dictionary/queueing_adj

American

https://www.collinsdictionary.com/us/dictionary/english/queuing
https://www.merriam-webster.com/dictionary/queuing

Yet every one of those pages list both versions as correct. So it seems very subjective.

So I think the bikeshed should be painted "queueing". 😂

Cheers,
-Derek

urvashi_vora’s picture

urvashi_vora commented

+1 for "Queueing", although both the spellings mean the same but going with the longer one.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

So I think the bikeshed should be painted "queueing".

Haha 😂

Queue + ing Seems the most logical for me as well. That's how I, as a non native English speaking person would write it.

jonathan1055’s picture

jonathan1055 commented

+1 for the full longer version queueing

Queue + ing Seems the most logical for me as well. That's how I, as a non native English speaking person would write it.

That is a good point, thanks.

Six people here agree with the longer version and no-one has wanted the shorter version. So that seems like we have reached an agreement.

quietone’s picture

quietone commented
Issue summary: View changes

Thanks everyone!

BramDriesen opened merge request !6536

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review

Updated patch to MR (and rebased). Also reverted the change in the core/vendor directory as I'm not sure we should be changing that.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Spellcheck output.

gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress
CSpell: Files checked: 15303, Issues found: 0 in 0 files
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Just realised the patch is not how it should be fixed. My bad. Will update to what is suggested in the IS.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

Updated to the correct implementation.

New cspell output.

gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress
CSpell: Files checked: 15303, Issues found: 0 in 0 files
dww’s picture

dww
we/he/they
commented
Title: spelling queueing vs. queuing » Use 'queueing' spelling instead of 'queuing'
Status: Needs review » Reviewed & tested by the community

GitLab CI won't really understand what "test-only" means here. 😂 So I just applied the change to the flagWords in core/.cspell.json and ran yarn run -s spellcheck:core. The only error I got was:

./core/lib/Drupal/Core/Database/Query/SelectInterface.php:331:42 - Forbidden word (queuing)

So flagWords is working as expected. The full pipeline is green, since that is fixed here in the MR.

The summary is clear and complete. I'm updating the title to try to be more appropriate for a commit message.

The MR is all good. This is ready.

Thanks!
-Derek

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
StatusFileSize
new Screenshot 2024-02-11 at 11.12.14.png39.7 KB

There is a test only run that you can trigger in GitLab CI 😉 I believe this is a run without the code changes and only test changes. But that doesn't help in this case

test only job

dww’s picture

dww
we/he/they
commented

Indeed, I’m very familiar with that job and how it works. I’m helping to get it ported into the contrib templates. #3418831: Test-only job. That’s why I said it would not help for this issue and why I did a “test-only” approach manually to make it easier for committers. 👍

  • quietone committed c574a6e4 on 11.x 
    Issue #3364292 by BramDriesen, dww, alison, cilefen, jonathan1055,...

  • quietone committed 73c1387c on 10.2.x 
    Issue #3364292 by BramDriesen, dww, alison, cilefen, jonathan1055,...
quietone’s picture

quietone commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed c574a6e and pushed to 11.x. Cherry picked to 10.2.x to keep dictionary in sync and there are no code changes here.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bramdriesen closed merge request !6536