Frontend Meeting - May 16 2023 Meeting in Slack

This is the frontend meeting for Drupal.org. This meeting takes place bi-weekly on Tuesdays at 3pm UTC (8:30pm IST, 5pm CEST, 11am EST, 8am PST). See Time.is to see what that is in your timezone.

UPDATE (transcript added)

Introductions
5 replies

katannshaw
mherchel
rolandoscott
andy-blum
markie

***

What agenda items would you like to discuss today (i.e. will be added as a topic)?
6 replies

mherchel

Would love it for people who've also noticed this to comment in the issue https://drupal.slack.com/archives/C0D5GJZ8B/p1684108547200409

mherchel
I can't be the only one to notice this, right? https://www.drupal.org/project/drupal/issues/3360245
blackbar.mp4

mherchel
and verify the fix

katannshaw
Added as topic 1

Rolando Scott
I would love some input into this issue i just created.. it drove me momentarily insane while doing some dialogs, thinking the ajax functionality was wrong or some library was missing, etc.
https://www.drupal.org/project/drupal/issues/3360753
Dialog: Fails 'silently' when page not found or page can't be loaded

katannshaw
@Rolando Scott Added as topic 2

Rolando Scott
thanks!

***

Any further general updates from the maintainers or product managers?
0 replies

***

Where can contributors help this week? (Note: If you want your item added to a new topic thread, add a thread icon with it)
0 replies

***

Any other general #frontend subjects to discuss can go here
0 replies

***

Fun question: If you’re going to DrupalCon Pittsburg, what are you most looking forward to? If not, what will you miss?
5 replies

mherchel
Contribution day (and the Lulla-party!)

mherchel
goes to get lunch

Rolando Scott
I work remotely.. so being with some of the people i work with, every day, but in a real setting and being able to connect and just socialize with them for real, is always great.. i will defend remote work till the death (so dramatic) but these spaces to actually connect and socialize are also needed for sure

katannshaw

I work remotely as well. I’m looking forward to seeing friends/colleagues.

markie
the hallway track

***

TOPIC 1: Would love it for people who’ve also noticed this to comment in the issue https://drupal.slack.com/archives/C0D5GJZ8B/p1684108547200409

mherchel
I can't be the only one to notice this, right? https://www.drupal.org/project/drupal/issues/3360245
blackbar.mp4

***

TOPIC 2: https://www.drupal.org/project/drupal/issues/3360753
Dialog: Fails 'silently' when page not found or page can't be loaded
0 replies

***

TOPIC 3: @alexpott shouldnt {{ dump() }} in twig be using the symfony var dumper?
In 10.1 beta, it’s giving me php’s var_dumper, I think?
andy-blum @alexpott shouldnt {{ dump() }} in twig be using the symfony var dumper?
In 10.1 beta, it’s giving me php’s var_dumper, I think?
Screenshot 2023-05-16 at 12.03.48 PM.png
86 replies

alexpott
Do you have dev dependencies installed?

andy-blum
Not sure what you mean by that

alexpott
What was the composer command you used to create your site?

andy-blum
oh man that’s been forever.
Screenshot 2023-05-16 at 12.07.34 PM.png

alexpott
composer require drupal/core=dev --dev

alexpott
might be what you need

andy-blum
The symfony dumper is available using dump() in PHP

andy-blum
should it not also be available in twig then?

alexpott
interesting

alexpott
well dump in twig is definitely using the symfony dumper

alexpott
it would error if symfony/var_dumper is not there…

alexpott
So something else is going on.

alexpott
Sorry for the red herring

alexpott
Here’s a SWAG

alexpott
disable devel

alexpott
Maybe devel 5 is adding a dump function that is overriding core.

andy-blum
2 files
Screenshot 2023-05-16 at 12.13.55 PM.png

andy-blum
disabling devel makes no difference

alexpott
Are those screenshots of you debugging? Because then it must be using dump

andy-blum
Yeah, that’s my current xdebug

andy-blum
Is there some library that needs to attach that’s missing?

alexpott
Hack it and set $_SERVER['VAR_DUMPER_FORMAT'] === 'html'

andy-blum
no change

andy-blum
Warning: Undefined array key "VAR_DUMPER_FORMAT" in Drupal\Core\Template\DebugExtension::dump() (line 58 of core/lib/Drupal/Core/Template/DebugExtension.php).

alexpott
$_SERVER['VAR_DUMPER_FORMAT'] = 'html'

alexpott
lol oops

mario
I think in Devel settings you can change the format for debugging to display in a more readable/user friendly way

andy-blum
oh this definitely is the symfony dumper
Screenshot 2023-05-16 at 12.24.22 PM.png

andy-blum
console:en:503 Uncaught ReferenceError: Sfdump is not defined

andy-blum
If I send a dump() in both the twig and the PHP then the twig one styles properly

andy-blum
Screenshot 2023-05-16 at 12.29.31 PM.png

andy-blum
but once I remove the PHP one:
Screenshot 2023-05-16 at 12.30.26 PM.png

alexpott
So this is something about how assets are attached.

andy-blum

the Sfdump function comes from
/**
* Dumps the HTML header.
*
* @return string
*/
protected function getDumpHeader()

andy-blum
vendor/symfony/var-dumper/Dumper/HtmlDumper.php

alexpott
There’s definitely something we need to do here :slightly_smiling_face:

alexpott
I think things have changed in Sf6 since we added dump() that are affecting us.

andy-blum
I leave this in your capable hands, then

alexpott
Hmmm…. my capable hands are going on holiday till 1st September :disappointed:

andy-blum
noooooo

andy-blum
who do I need to pester

alexpott
From 21st may…

andy-blum
opening an issue now

andy-blum
what component does this belong in?

andy-blum
https://www.drupal.org/project/drupal/issues/3360774
Twig's dump function doesn't attach symfony assets

andy-blum
cc @lauriii @bnjmnm

mherchel
@andy-blum Lauri and Ben are out for the week I believe. I also believe that Twig debug needs to be enabled

andy-blum
@mherchel twig debug is enabled, via the fancy new checkboxes :sunglasses:

mherchel
Nice! Working now?

andy-blum
No, it’s still borked

mherchel
weird. FWIW I had it working on 10.1.beta-1 earlier today. No issues

andy-blum
Did some additional testing this morning and it seems this is in some way scoped to umami

alexpott
That’s interesting - hmmm

mherchel
:question: :question: :question: :question: :question:

mherchel
huh (1 MB)
https://media2.giphy.com/media/kc0kqKNFu7v35gPkwB/giphy.gif?cid=6104955e...

mherchel
You gonna track it down
@andy-blum? If not, I might have time. This sounds kinda fun

andy-blum
I’m not really sure how to trace this down

andy-blum
follow the white rabbit (566 kB)
https://media3.giphy.com/media/swtiK9jRfE0zS/giphy.gif?cid=6104955eic20g...

alexpott
Another SWAG - try disabling big_pipe

andy-blum
nada

alexpott
:( damn

andy-blum
cc @markconroy & @shaal

andy-blum
as umami maintainers

shaal
:eyes:

alexpott
@andy-blum it’d be awesome if you can answer https://www.drupal.org/project/drupal/issues/3360774#comment-15055262 or provide very explicit steps to reproduce…
Twig's dump function doesn't attach symfony assets when using the umami profile

andy-blum
Updated - if I put the debugger where Alex put it, everything works

andy-blum
the exact case that breaks for me is in the system branding block (edited)

mherchel
huh (1 MB)
https://media0.giphy.com/media/kc0kqKNFu7v35gPkwB/giphy.gif?cid=6104955e...

andy-blum
I’m going to try a different block and see if it works there

andy-blum
block--bundle--banner-block.html.twig also fails

andy-blum
kept the demo_umami installation
changed theme to olivero
added dump to system-branding block
symfony works fine

andy-blum
so limited to umami theme, in block templates

andy-blum
Trying a standard install with umami theme now

andy-blum
Still breaks here, so it’s limited to the theme aspect of umami, and isn’t caused by the profile aspect

andy-blum
Could this be related?
https://github.com/symfony/symfony/pull/48048
#48048 [WebProfilerBundle] Fix dump header not being displayed
The bug occurs because of the following log message:
The "Symfony\Bridge\Doctrine\Logger\DbalLogger" class implements "Doctrine\DBAL\Logging\SQLLogger" that is deprecated Use {@see \Doctrine\DBAL\Logging\Middleware} or implement {@see \Doctrine\DBAL\Driver\Middleware} instead.
Since this is the first message and it contains the { character the dump header gets rendered (line 93):
symfony/src/Symfony/Bundle/WebProfilerBundle/Twig/WebProfilerExtension.php
Lines 88 to 104 in f9eaefa
However, since there is no actual placeholder to replace, the header is never displayed, but is marked as displayed and never rendered again:
symfony/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
Lines 149 to 152 i… Show more
Labels
Bug, WebProfilerBundle, Status: Reviewed
Comments
7
symfony/symfony | Oct 29th, 2022 | Added by GitHub

andy-blum
Got an answer in the issue, it’s from the use of |render|striptags|trim

andy-blum
taking those out of the templates the headers go through fine

mherchel
looking

mherchel
so, i'm a bit confused. If you use |render on anywhere in the template, dump() will not work?

mherchel
or is it if you use |render on a content item and then dump that?

andy-blum
I don’t 100% get it, but I think what’s happening is that we’re technically rendering the content three different times.
Screenshot 2023-05-18 at 11.01.48 AM.png

andy-blum
once per if statement, and then when we actually print out the region

andy-blum
that render function running multiple times over the same content is the issue

andy-blum
so if the branding block is in the header region, removing page.header|render from the two if statements lets it work

markconroy
Looks like we need to get this issue solved once-and-for-all
https://www.drupal.org/project/drupal/issues/953034

andy-blum
At least for my exact use case I know I can remove the render checks from umami, so that’s good

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3360739