"Add or select media" not translated

Created a patch for translating the title of media library dialog after enabling it for text format. Attached the screenshot as well. Please review.

Thank you for reporting the issue.

Next step will be to get a test assertion in place to check that it's properly translated.

@ameymudras that's the test-only patch FYI that you're carrying forward.

@miikamakarainen if that's where you want to place them you should use the t() function. So we don't have to pull cspell ignroes in.

Correct but when you use the t('Add or select media') it will check for the translated string. Or else we have to cspell ignore those specific lines as they are failing the custom commands.

Correct but when you use the t('Add or select media') it will check for the translated string. Or else we have to cspell ignore those specific lines as they are failing the custom commands.

I disagree with using t in the tests themselves. See https://www.drupal.org/project/drupal/issues/2875148 for background info

I have uploaded the patch
Fixed CCF

But in this scenario we are testing translations

Hiding 14 as it removes the fix to the problem.

I was going to say "but CKEditor 5 plugin labels are translatable and they're also defined in that YAML file, so why don't these work?"

The answer: \Drupal\ckeditor5\Annotation\DrupalAspectsOfCKEditor5Plugin::$label has:

  /**
   * The human-readable name of the CKEditor plugin.
   *
   * @var \Drupal\Core\Annotation\Translation
   * @ingroup plugin_translatable
   */
  public $label;

Such annotations are not possible for each plugin's custom metadata…

So +1 for this.

#13: I think @smustgrave is right in #15 — see \Drupal\Tests\ckeditor5\FunctionalJavascript\LanguageTest::test() for example 😅

1. +++ b/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php
   @@ -151,7 +151,9 @@ public function testMediaLibraryTranslations() {
   +    $this->assertSame('Media toevoegen of selecteren', $header_text);
   

   Just add

   // cSpell:disable-next-line
   

   above this line.

2. +++ b/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php
   @@ -164,7 +166,9 @@ public function testMediaLibraryTranslations() {
   +    $this->assertSame('Añadir o seleccionar medio', $header_text);
   

   Same here.

… then this will pass tests and I'll RTBC 😊

make changes as per #16

Attempted to fix error patch #17

#23 will not apply because it was relative to web/core, not core.

But you're right, even after enabling the locale module, the translation test is not working. In hindsight, I was wrong in #16 — because \Drupal\Tests\ckeditor5\FunctionalJavascript\LanguageTest::test() is testing CKEditor 5's UI translations, not Drupal's!

So per #2875148: BrowserTestBase: Steer new test development away from translation, we AFAICT should simply not have any test coverage for this. Is that right, @borisson_?

So per #2875148: BrowserTestBase: Steer new test development away from translation, we AFAICT should simply not have any test coverage for this. Is that right, @borisson_?

Yes, this was also discussed in slack, and catch agreed that there is no test coverage needed. So #5 should be correct patch here.

Re-uploading #5 🤓

This should address the failing custom commands.

Committed to 10.1.x. and backported to 10.0.x and 9.5.x

Thanks all