Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Standing items
- Who is here?
- What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
- Action Items
- Approve previous minutes
- Wrap up
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| longwave | Dave, UK |
0️⃣.5️⃣ What are you reading lately?
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
2️⃣.2️⃣ Approve last fortnight's minutes
| quietone | #3309707: Coding Standards Meeting 2022-09-28 2100 UTC |
| quietone | #3312735: Coding Standards Meeting 2022-10-12 2100 UTC |
| quietone | #3319822: Coding Standards Meeting 2022-11-09 2200 UTC |
| quietone | All those are at Needs Review |
3️⃣ Target issues
| quietone | In the 12 Oct meeting, I suggested adding #3268741: [meta] Fix Drupal.Commenting.DocComment.ShortSingleLine as the target. |
| quietone | There was no objection so I am adding to the bookmarks in the channel |
I forgot to add point 1!1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | Target issues |
| quietone | Restructure meta issues and documentation |
| quietone | Ideas on how the DA can support this work |
4️⃣ Restructure meta issues and documenation
| quietone | Much of the effort has been on PHP and when issues or documentation is added for other languages they are added but also hard to find. |
| quietone | In an effort to organize related issues, I created #3319843: [Meta] Fix coding standards in core which has children, usually another meta, for JavsScript, CSS etc. |
| quietone | As we find issues, we can now make them children of the respective meta so they are not lost in the queue. |
| quietone | Similarly, I think the same should be done to the wiki page, https://www.drupal.org/docs/develop/standards |
| quietone | Ultimately, I'd like there to be guides for PHP, JavaScript, CSS, markdown, SQL, Composer, and possible testing. Some of those do exist as a guide and others are pages. The most helpful one to do though is PHP. (edited) |
| quietone | By my count there are 10 pages there that could be moved to a new PHP guide. |
| quietone | I image that many folks will have bookmarked the pages, so redirects will be needed. |
| quietone | What do you think? |
| longwave | Reviewing and restructuring the existing documentation sounds good. It has sort of grown organically from pre-OO coding standards and it could do with restructuring in places I feel. |
| borisson_ | I agree that this change would be useful, but that would mean a big effort. I personally don't have the energy to start this effort. |
| quietone | No worries, I will do the work. I recently moved things around for this guide and I found the time it took acceptable to me. |
5️⃣ Ideas on how the DA can support this work
| quietone | A continuation from last meeting. Maybe someone had some ideas over the last fornight? |
| quietone | Can the DA help get discussion/movement on #3252921: Add members to and remove members from the Technical Working Group |
| longwave | It would also be good if we can get DrupalCI to set patches back to needs work that fail coding standards (or other checks), at the moment they stay needs review - this is a change the DA would have to make |
| longwave | #2021489: [Policy] Automatically check whether 'needs review' patches apply and pass linting#new |
| borisson_ | that's probably not going to happen on drupalci, but probably something gitlabci needs to introduce? |
| borisson_ | But I agree, adding members to the CS committee is something the DA can help with, that would be really helpful for us, and give us some "official" capacities |
6️⃣ Wrap Up (edited)
| quietone | Cheers |
Comments
Comment #4
quietone commentedComment #5
smustgrave commented@quietone went into #coding-standard channel and reviewed the minutes. I see that xjm comments on #4 but after the 1 day window does that need to be captured?
if not everything else looks good and those who contributed to discussion have been credited.
Comment #6
smustgrave commentedAssuming the 24 hour rule is in affect.
Comment #8
quietone commentedAdding 2 comments that were posted after the 24 hours of the meeting.
4️⃣ Restructure meta issues and documenation
My only concern would be that there are some general principles that apply to more than one language, or specific standards like 2-char spacing, but I think we can find a way to handle both those things. Something as trivial as the indentation should be repeated in the relevant docs, and we can create a section at the top for any of the general principle stuff if it turns up/turns out to be useful.
Comment #9
quietone commentedThis should be in the Coding Standards project.