Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Standing items
- Who is here?
- What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
- Action Items
- Approve previous minutes
- Wrap up
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| hestenet (he/him) | Tim from the DA checking in :wave::skin-tone-3: |
| Björn Brala (bbrala) | Bjorn checking in, while listening to an auditor asking questions to my colleages heh |
0️⃣.5️⃣ Which one fictional place would you most like to visit?
| hestenet (he/him) | Narnia |
| hestenet (he/him) | Too deeply ingrained in my childhood. I'm sure other places are cool :sweat_smile: |
| quietone | The moon, Anarres, from The Dispossessed by Ursula K. Le Guin |
| hestenet (he/him) | Oh such a good one. My tattoos are from Left Hand of Darkness. |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | Confirm point #3 from previous meeting, https://drupal.slack.com/archives/C02LJCF78E8/p1665551284524059 |
| quietone | A stale Coding standards issue, #2902865: Loosen the lowerCamel requirement |
| quietone | Identify policy coding standards issue in core queue |
| hestenet (he/him) | Topic: Can the DA support this work? We can amplify any calls to action/get the word out |
2️⃣ Action items
| quietone | @quietone - follow up on #3252921: Add members to and remove members from the Technical Working Group |
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
2️⃣.2️⃣ Approve last fortnight's minutes
| quietone | There are two minutes that need to be approved. #3309707: Coding Standards Meeting 2022-09-28 2100 UTC and #3312735: Coding Standards Meeting 2022-10-12 2100 UTC |
3️⃣ Confirm point #3 from previous meeting, https://drupal.slack.com/archives/C02LJCF78E8/p1665551284524059
| quietone | In the previous meeting @Björn Brala (bbrala) suggested what to do when we 'close' an issue in the Coding Standards queue. This is needed because there is no one active here that is a member of the Coding Standards committee, part of the TWG. We can only go so far, and we can't adjust credit on those issues either. |
| quietone | The suggestion was to set the issue to RTBC with the following text."We are currently a small group working on getting Drupal's coding standards moving, we are no official maintainers. Join us in #coding-standards in slack if you want to help." |
| quietone | I think that text explains the situation clearly. It can be added to either the Issue Summary and comment or both. |
| quietone | I am happy to go with that text. |
| quietone | What are your thoughts? |
| Björn Brala (bbrala) | I would be happy with that text. |
4️⃣ A stale Coding standards issue, #2902865: Loosen the lowerCamel requirement
| quietone | This is about the lowerCamel case and acronyms. There has been no activity for 5 years and the consensus appears to not support the suggested change. That is, to keep the current naming method. |
| quietone | I am thinking this is a won't fix. (edited) |
| Björn Brala (bbrala) | Yeah, might as well close it up and clean up. |
5️⃣ Identify policy coding standards issue in core queue
| quietone | I've noticed a few issues in the core queue about coding standards that have not been in the coding standards queue. I think we need to find them and decide what to do with each one. |
| quietone | For example, #3250827: [policy, no patch] Use declare(strict_types=1) in new code |
| quietone | #3154762: [policy, no patch] All new Drupal 10 code should use appropriate type hints wherever possible |
| quietone | #3030640: [policy, documentation] Clarify Constructor BC policy and document best practices for subclassing other classes |
| quietone | #3218030: [meta] Always use named arguments when creating a class instance |
| quietone | #3183180: [policy, no patch] Document named arguments BC policy |
| Björn Brala (bbrala) | Setting a reminder for this one :slightly_smiling_face: |
6️⃣ Can the DA support this work? We can amplify any calls to action/get the word out
| quietone | Thanks for the offer! |
| quietone | I am not sure how to best use this. It is late here so I'll sleep on that. And maybe others will have some ideas. |
| hestenet (he/him) | Understood! Just let me know. |
Comments
Comment #4
quietone commentedComment #5
smustgrave commentedCame across this issue for the needs review initiative.
Went to the slack channel and saw some missing data.
Missing @borisson_
and a few comments from him in the threads.
Should I update?
Comment #6
quietone commentedThanks for checking the minutes.
I looked at the Slack discussions and the comments by borrisson_ are after the 24 hour window of the meeting (unless I am mistaken).
The Coding Standards meeting is open for 24 hours and then the minutes can be created. People often do continue to comment but only the comments made during the 24 hours window of the meeting must be recorded. It is true that if the minutes are created, say 3 days after the meeting end that comments after the official end of the meeting will be included. We do not expect the transcriber of the minutes to regularly go back and check for comments after the 24 hour period nor to trim comments made after the 24 hour period.
Comment #7
smustgrave commentedIn that case everything looked good
Comment #8
quietone commentedThese minutes can be marked fixed once it have been reviewed and credit is applied. The core committers don't need to see these issues.
I am crediting smustgrave for the review and marking fixed.
Comment #10
quietone commentedThis should be in the Coding Standards project.