Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Standing items
- Who is here?
- What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
- Action Items
- Approve previous minutes
- Wrap up
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
0️⃣.5️⃣ In what environment are you when you get a new idea?
| quietone | When I am walking. (Before I reduced my water usage it was the showed). |
| Björn Brala (bbrala) | Pff, ideally in a quiet relaxing enviroment, shower is a good place normally, but vacations are great also :slightly_smiling_face: |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | When closing an issue as an result of our meeting, what should we close it as? We are no maintainers on coding standard project, therefor, things like credits and such are impossible to give. I decided on RTBC 2 weeks ago, but i'd like to get agreement on this. From @Björn Brala (bbrala) |
| quietone | Update on beta targets |
| quietone | Setting new core issue targets (edited) |
| quietone | Following up from last meeting on #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL |
| Björn Brala (bbrala) | Hmm |
2️⃣ Action items
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
2️⃣.2️⃣ Approve last fortnight's minutes
| quietone | #3309707: Coding Standards Meeting 2022-09-28 2100 UTC |
3️⃣ When closing an issue as an result of our meeting, what should we close it as? We are no maintainers on coding standard project, therefor, things like credits and such are impossible to give. I decided on RTBC 2 weeks ago, but i'd like to get agreement on this. From @Björn Brala (bbrala)
| quietone | This seems the best we can do right now. |
| quietone | Perhaps adding a comment explaining that we are doing our best as a group but are not maintainers, that we are seeking official recognition? Or some nice words around that. |
| Björn Brala (bbrala) | It is pretty much all we can do at the moment. :disappointed: |
| Björn Brala (bbrala) | The contact with the last active maintainer didn't really work out i think? |
| Björn Brala (bbrala) | Perhaps we should just go through the normal process of getting maintainership of the project. Although asking for ownership might be best. |
| Björn Brala (bbrala) | This will wake up quite a few people probably. |
| Björn Brala (bbrala) | I do agree though, a Text about who we are and why we do this when doing that would be a very good idea |
| Björn Brala (bbrala) | because this will also create visibility of the issue (edited) |
| Björn Brala (bbrala) | "We are currently a small group working on getting Drupal's coding standards moving, we are no official maintainers. Join us in #coding-standards in slack if you want to help." |
4️⃣ Update on beta targets
| quietone | All the issues we set for being ready for commit during beta have been commited. |
| quietone | Really glad that we did not take on too much. |
| Björn Brala (bbrala) | A lot of time i think is also still discovery, and the issue with CS issues is the fact this is a thing a lot of people also have opinions on. But still; we should be proud things are moving. And YOU should be proud, I'm very thanksfull of the energy you inserting in this process. Thank you @quietone. |
5️⃣ Setting new core issue targets
| quietone | We probably need some smaller, non-disruptive patches now. Although we can still choose disruptive ones for the next beta. |
| quietone | I started adding the number of files/fixes needed to the issues. There are some on the Meta and then on some of the children. I don't recall which ones I have done, so a bit of poking around is needed. (edited) |
| quietone | Because I worked on it I know that this one is close. It was ready but then got split because of size, so there are now smaller children. I am hoping it is just reviews and keeping the patch up to date. (edited) |
| Björn Brala (bbrala) | I'll reserve some crontribution time to work on there friday |
6️⃣ Followup on #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL
| quietone | Rereading the discussion from the previous meeting there does not seem to be a consensus. |
| quietone | Thoughts? Next steps? |
| Björn Brala (bbrala) | There are some good arguments in the issue. I will post in parent thread to ask if the people who commented in the thread should do so in the issue also |
| Björn Brala (bbrala) | Personally i think explicit null is way better and there are valid arguments also to do that:#3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL#comment-14710826 for example is pretty much the best reason imo. Less return type changes in the future then also. |
| Björn Brala (bbrala) | Posted in parent thread. |
| Björn Brala (bbrala) | I'll put this in my queue also. xD |
Participants:
quietone, Björn Brala (bbrala)
Comments
Comment #2
quietone commentedRe-posting comment #2 from the previous minutes, which was missed as a discussion topic. @bbrala, apologies for that oversight.
Comment #4
quietone commentedComment #5
quietone commentedAdd missing links
Comment #6
smustgrave commentedWent back to the coding-standard channel and reviewed the meeting and all the notes were captured.
Comment #8
quietone commentedThis should be in the Coding Standards project.