Claro - March 23 2022 Meeting in Slack

This meeting takes place every Wednesday at at 3pm UTC (8:30pm IST, 4pm CET, 10am ET, 7am PST). See Time.is to see what that is in your timezone.

The meetings are held using Slack threads in the #admin-ui Slack channel.

UPDATED (transcript added)

Introductions
10 replies

katannshaw
andy-blum
ckrina
mherchel
deviantintegral
cindytwilliams
lauriii
Gábor Hojtsy (he/him)
shaal
saschaeggi

***

What agenda items would you like to discuss today?
4 replies

andy-blum
Do we still need to test linkit against claro in 10.0.x? It sounded like there might be considerable differences with CKE5.
https://www.drupal.org/project/drupal/issues/3219921
Claro: display the vertical scrollbar when many results are returned by linkit

deviantintegral
I can dedicate an hour this week for either testing, or back-end focused code review or dev work.

ckrina
then, @katannshaw could you add a thread to “Issues ready for testing”?

***

Where can contributors help this week? There will be threads for the individual components
6 replies

ckrina
Preprocess functions & small CSS: https://www.drupal.org/project/drupal/issues/3099026
Claro's preprocessing of field multiple value form's table header cell removes potential changes by others

katannshaw
@ckrina Ok I’ll add this as a new topic, cool?

ckrina
no needed I think

ckrina
I’m just sharing the link

katannshaw
Ok :thumbsup:

ckrina
This one just needs a “reroll”, making this work with 9.4 https://www.drupal.org/project/drupal/issues/3214332
Preview content is broken in Claro.

***

Topic 1: Claro: display the vertical scrollbar when many results are returned by linkit
https://www.drupal.org/project/drupal/issues/3219921
1 reply

ckrina
I just moved it to RTBC!

***

Topic 2: Assess accessibility of Claro in High Contrast AKA forced colors mode
https://www.drupal.org/project/drupal/issues/3080100
8 replies

mherchel
There are a number of known forced colors / high contrast issues, and possibly more unknowns. The fixes for these are usually somewhat straightforward, but the issues are a pain because testing them is really involved. You need Windows (I use a virtual machine) ,and then you have to test various browsers.

mherchel
I'd like to put together a team. We need at least three people:
1. Person to create the patch
2. Person to test - this is often just as difficult as creating the patch and is really involved
3. Person to commit - this will need to be either @ckrina or @lauriii

mherchel
on top of all of that, we're also in this weird space where we need to create separate patches for 9.4.x and 10.0.x. So that makes each task (almost) twice as hard

mherchel
that all being said, it's totally doable. I think once we get into a groove, we can knock down several of these per week, and be done with it by DrupalCon

lauriii
Sounds like a good plan

lauriii
I’m also happy to provide reviews if @ckrina or @bnjmnm wants to commit them :slightly_smiling_face:

mherchel
This one needs a review (currently only have a D10 patch) https://www.drupal.org/project/drupal/issues/3269341

mherchel
and this one is RTBC if you want to take a look https://www.drupal.org/project/drupal/issues/3171728
Claro Select form element needs Windows High Contrast mode improvements

***

Topic 3: Issues ready for testing
13 replies

andy-blum
https://www.drupal.org/project/drupal/issues/3067697
https://www.drupal.org/project/drupal/issues/3081489
:point_up: these both had failed tests, but we’ve seen some false failures in Olivero, so I re-queued them this morning, just in case. If they fail again, we’ll need to address

ckrina
Those 2 have priority because they’re stable blockers (edited)

deviantintegral
Do those two need any manual review, or are they rtbc if they pass?

andy-blum
@deviantintegral I think they still need eyes on them

andy-blum
but I wouldn’t bother reviewing until tests pass

ckrina
Another stable blocker (but needs hight contrast mode) https://www.drupal.org/project/drupal/issues/3269341 (edited)
Claro element not rendering properly in forced colors

ckrina
A really nice UI improvement that is almost there, and needs both PHP & classing front-end experience: https://www.drupal.org/project/drupal/issues/3082672 (edited)
Form prefix/suffix redesign in Claro

ckrina
^ @deviantintegral this is a really good want if you want to invest some time reviewing, even if it’s just the PHP part

deviantintegral
Perfect!

ckrina
Some JS testing needed here: https://www.drupal.org/project/drupal/issues/3225621
Use media query event listener instead of a listener on the resize event

ckrina
This needs review also, and probably updating the branch/reroll. Requirements: PHP&CSS https://www.drupal.org/project/drupal/issues/3023322 (edited)
Contextual Links Style Update

andy-blum
Both issues I mentioned above had the tests fail again

ckrina
Another one that needs testing, blocking several other issues: https://www.drupal.org/project/drupal/issues/3251709
Define Blue scale for Claro

***

Topic 4: [META] Assess Claro’s conformance with WCAG Text spacing, Text resize, and Reflow. https://www.drupal.org/project/drupal/issues/3087225
0 replies

***

Topic 5: [META] Assess Claro for WCAG colour contrast AA conformance https://www.drupal.org/project/drupal/issues/3088562
0 replies

***

Topic 6: [META] Assess conformance with WCAG SC 2.4.7 “Focus Visible” https://www.drupal.org/project/drupal/issues/3163810
0 replies

***

Any additional topics to discuss?
14 replies

andy-blum
@ckrina what’s our deadline to get all the stable blockers done?

ckrina
Kat added that into the meeting notes

ckrina
maybe this would need an independent thread on the next meeting so we can discuss it further

ckrina
mid-may is the date for gettting into D10

ckrina
but we need to get Claro as stable before

andy-blum
Spread the word!
https://twitter.com/andy__blum/status/1506638148570337288

andy-blum
I feel dirty using that many emojis in a tweet

Gábor Hojtsy (he/him)
Instant RT though :stuck_out_tongue:

Gábor Hojtsy (he/him)
Do we know that we have all the outstanding stable blockers listed? Are there potential stable blockers hiding in issues or testing issues that may generate more?

ckrina
We haven’t gone through all the 180+ issues yet, I think we’ve covered 40% of them? (edited)

Gábor Hojtsy (he/him)
Do we expect that is a problem, would there be things sitting there?

ckrina
I’m not sure about that, sorry

ckrina
I think I’ve read all of them at some point and they didn’t raise concerns, but I could have forgotten or over-sight a few

Gábor Hojtsy (he/him)
That sounds good enough for me honestly.

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3271200

Thanks @katannshaw for running this! It helps a lot! :raised_hands: (edited)