Problem/Motivation

Steps to reproduce

Proposed resolution

  1. ✅ Create a section on Deprecated and obsolete modules and themes to provide recommendations for sites using module MODULE_NAME. The recommendation are to include instructions for sites using MODULE_NAME and for contributed modules that depend on MODULE_NAME.
  2. ✅ Set lifecycle to deprecated.
  3. ✅ Set lifecylcle_link to the section added above, https://www.drupal.org/node//3223395#s-MODULE_NAME.
  4. ✅ Add @group legacy to the tests in the module.
  5. ✅ The change record for this issue includes a link to the doc page. Create a section on https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...
  6. ✅ Section on wiki page, https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...
  7. ✅ Change record, use https://www.drupal.org/node/3263629 as an example

Remaining tasks

Maintainer for contrib RDF #3304913: Offering to co-maintain RDF
Commit

User interface changes

API changes

Data model changes

Release notes snippet

RDF module has been deprecated from Drupal 9.5.0, and will be removed from core in Drupal 10.0.0..

CommentFileSizeAuthor
#9 3267703-9.patch16.8 KBlongwave
#5 3267703-5.patch12.05 KBquietone
#5 diff-2-5.txt470 bytesquietone
#2 3267703-2.patch12.04 KBquietone

Issue fork drupal-3267703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
FileSize
3267703-2.patch12.04 KB

Starting off.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue tags: +Needs change record

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
FileSize
diff-2-5.txt470 bytes
3267703-5.patch12.05 KB

Updating the patch and running tests because RDF has been removed from the standard profile.

longwave made their first commit to this issue’s fork.

longwave opened merge request !2624

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Converted to an MR, also opened #3302984: Remove RDF module from Umami which needs to be done first - we can't have Umami installing a deprecated module.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3267703-9.patch16.8 KB

Combining the MR with #3302984: Remove RDF module from Umami to see which tests still fail after Umami is fixed.

Status: Needs review » Needs work

The last submitted patch, 9: 3267703-9.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Done a bit more work on this one, still some more to go. Opened #3303278: Decouple NodeDisplayConfigurableTest from RDF module as I think that is worth doing separately.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

DefaultConfigTest throws a deprecation because Forum and User contain optional RDF config, opened #3303435: Move RDF-related optional config to RDF module

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

To be able to commit this one, we'd need a contrib maintainer for RDF module and a 9.5/10.0 compatible release at https://www.drupal.org/project/rdf (which already exists for the Drupal 6 version so would need to be taken over).

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes

Updated the IS with the remaining tasks.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue summary: View changes
Issue tags: -Needs change record

Added a change notice: https://www.drupal.org/node/3304899

Copied the HAL change notice but also added a note for users who may have installed it from standard but don't know what it is - it is almost certain they can safely remove it.

The three failing tests here should be resolved when #3293813: Move RDF-related tests to RDF module lands.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

Added an RDF section to the wiki page, although there is no link to the contributed module. I was sure if /project/rdf will be used.

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented

We are in the process of getting project/rdf ownership. Should land there.

#3293813: Move RDF-related tests to RDF module has been marked RTBC by me, hopefully that gets committed soon.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review

Rebased following #3293813: Move RDF-related tests to RDF module

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

This is now ready for review.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

Hiding patches in favor of the merge request.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes

Update IS

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

Fix link for the RDF maintainership

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

So looking at the MR looks like everything was covered. RTBC for the MR.

For the change record should it link to the contrib module?

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

The steps to implement the deprecation and removal of an extension say the the CRs are to point to the wiki page. Then wiki page is to have the details of how to handle the change. I can't find the discussion around that, sorry.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

So should this be updated to point to the contrib module https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

Aboslutely! Well spotted.

And when the deprecation happens RDF will move to the section, Recommendations for deprecated modules. It should also include what versions of Drupal it requires. At least that helps the reader, they don't have to go off and read every project page to find that detail when planning an upgrade. As it happens, I just added that to some of the other extensions being removed.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

Sweet. So RTBC for this. Unless something else is needed?

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented

RDF now has a stable release #3306737: Create a release of the subtree split of Drupal Core. Also note it requires drupal ^9.5/^10.0.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes
Status: Needs review » Needs work

Updated the issue summary with completed tasks.

It still looks like \Drupal\Tests\rdf\Functional\Node\NodeDisplayConfigurableTest still needs the legacy group.

Other than that, this is done. There's a contrib module with a stable release ready to pick up the slack. Once that final test is dealt with, this looks RTBC to me.

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented
Status: Needs work » Needs review

Added the missing tag

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thanks, @bbrala! As promised, RTBC once it passes tests.

  • catch committed 31995bc on 10.0.x 
    Issue #3267703 by longwave, quietone, bbrala, phenaproxima, smustgrave:...
  • catch committed eb15d89 on 10.1.x
    Issue #3267703 by longwave, quietone, bbrala, phenaproxima, smustgrave:...
  • catch committed 32bd7cb on 9.5.x
    Issue #3267703 by longwave, quietone, bbrala, phenaproxima, smustgrave:...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Very straightforward patch for a very not-straightforward removal process that first started in 2013.

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !2624