Olivero comment form should have title

Thanks! I thought Olivero may actually be doing something to actively undo this title? Or just does not contain it in the template?

Hi @mherchel, Now we're using the logic when we have comments then it will print the label, other wise it will not print it.

{% if comments and not label_hidden %}
    {{ title_prefix }}
    <h2{{ title_attributes.addClass('comments__title') }}>{{ label }} <span class="comments__count">{{ comment_count }}</span></h2>
    {{ title_suffix }}
  {% endif %}

I have removed the {{ comments }} the condition. Now comment label is visible without any comments. Added a patch and after patch screenshot for ref.

Applied patch #5 and it works fine.

Before patch;

After patch:

RTBC +1

Question is do we want the same title and the 0 counter or the different "Add new comment" title? How does the same form look like when there are comments already? (In Bartik and Olviero?)

Applied patch # 5 working but showing only comment label not Add new comment lable sharing screenshot....

New Patch updated

New Patch updated

Patch #14 applied successfuly and It's working fine.

Before patch SS:

After patch SS:

RTBC +1

Thanks!

Based on #8, we probably should review this in one of the UX meetings.

Moving to needs review based on #17.

Patch #14 applied successfuly.

Verified and tested patch #14.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/structure/types/manage/article/fields
# Click on Add field
# Select a Comment from "Add a new field"
# Mention the Label name
# Add into link field
# Save it.
# Create a Article content
# Save it
# User is not able to see "Comments" title on view page.

Expected Results:
# User should see "Comments" title on view page.

Actual Results:
# User is not able to see the "Comments" title on view page.

Looks good to me.
Can be a move to RTBC.

Based on #17, we still need to address #8.

Verified and tested patch #14.
Patch applied successfully and looks good

Testing Steps:


1. Goto: admin/structure/types/manage/article/fields

2. Click on Add field

3. Select a Comment from "Add a new field"

4. Mention the Label name

5. Add into link field
 & Save it.

6. Create a Article content
 & Save it

7. verify the user is not able to see "Comments" title on view page.

Expected Results:

User should see "Comments" title on view page.
Actual Results:

User is not able to see the "Comments" title on view page.

This can be a move to RTBC.

I did a re-roll of the patch in comment #14, please revise!

The related issue could improve UX but it still needs usability review

Verified and tested patch #24 on the drupal 9.3.x-dev version. Patch applied successfully.

Testing Steps:

• Goto admin/structure/types/manage/article/fields
• Click on Add field
• Select a Comment from "Add a new field" and Mention the Label name
• Add into link field & Save it.
• Create a Article content & Save it
• Verify the user is able to see "Comments" title on page.

Expected Result:

• User should see "Comments" title on page.

Actual Results:

• User is able to see "Comments" title on page.

Please refer attached screenshot.
This is can be move to RTBC.

Rolling up patch.

Patch applied successfully. Moving this to RTBC.

Before patch SS:

After patch SS:

Thanks!

Committed 7b8ebde and pushed to 9.3.x. Thanks!

Note I've removed some issue credit where manual testing was done on similar patches - once something has been manually tested with screenshots, it doesn't need doing so again on the same issue unless the approach radically changes.