mglaman |
I am hoping to take some upcoming flights to work on my core issues for JSON:API[#3105318]Meta normalization on resource objects, relationships(edited) |
mglaman |
Commerce API (JSON:API for Commerce module) should launch end of month :fingerscrossed: |
gabesullice |
I'd like to apologize to everyone for not being more on top of recording these meetings and giving drupal.org credit. I'll be better about that in the future. |
mglaman |
I’ll be at Drupal Dev Days where I’d like to demo Commerce API to folks. And discuss OpenAPI |
gabesullice |
I know Wim will be there. I think there's a high-probability I'll be there too :slightly_smiling_face: not guaranteed yet. |
e0ipso |
Kudos to @phenaproxima (he/him) for working on D9 readiness issues on decoupled modules for Lightning |
prestonso (he/him) |
Decoupled Days CfP closes in less than a month! https://docs.google.com/forms/d/e/1FAIpQLScgdojEbV_I_tB1AmeOxkO7-5UzSkV_... |
eli-t |
I'll be talking at DrupalCamp London on how we're using JSON:API to syndicate content and the JSON:API Reference module |
morbus (they/them) |
I continue to work on my “use local JSON:API install during module installation for migrating content in” and it’s working swimmingly. Nearly finished my conversions from YAML Content, and then I’ll be doing some basic Commerce JSON:API work. |
morbus (they/them) |
@mglaman definitely interested in your Commerce API work and what it will enhance/do over base JSON:API. |
mglaman |
Make it usable for Commerce :upside_down_face: |
mglaman |
I mean it is usable, but the client experience is very unusable for Cart and Checkout |
morbus (they/them) |
How is it not currently usable? |
mglaman |
JSON:API is great for order management in machine to machine |
morbus (they/them) |
Got it. Yeah. I’ve wondered how payments would work. |
mglaman |
or just fetching products |
mglaman |
JSON:API is :100: for CRUD. But Commerce (ecommerce in general) has a lot of non-strictly-CRUD requirements. (edited) |
morbus (they/them) |
Yeah. Taxes, CC capture, etc. |
mglaman |
also, /jsonapi/commerce_product/default is eee, now it’s /jsonapi/products/default |
mglaman |
or just /jsonapi/currencies |
morbus (they/them) |
We were planing to make REST endpoints for some of that stuff but hopefully Commerce API will do it for us. |
mglaman |
Trying to finalize an alpha by end of the month. It’s working for a client using Klarna checkout in their React app for offsite payments |
morbus (they/them) |
Does it have to be that? If I install Conmerce API will I have to rewrite existing code? Or are they aliases? |
mglaman |
You’ll have to rewrite code. We make full assumptions over commerce entity type resource types. |
morbus (they/them) |
I use both of the ones above already. |
morbus (they/them) |
Currencies, Store, and Products I’m using in an importer |
mglaman |
So installing and using commerce_api will be a BC break for existing builds |
mglaman |
Although it’s reversable |
morbus (they/them) |
Hrm. Maybe I should wait until I fully convert that stuff, then. I just wrote today against commerce_store/order and currency. |
mglaman |
well it’s just renaming URLs and resource types |
mglaman |
so it’s not a big change |
morbus (they/them) |
Seems easy enough. |
mglaman |
That’s why I haven’t released. Because I need to write these docs :slightly_smiling_face: |
morbus (they/them) |
Not sure I like the lack of name spacing though. |
morbus (they/them) |
(Is, losing commerce_) |
mglaman |
Explaining your eCommerce API docs where everything is prefixed “commerce_” is ugly |
mglaman |
Like I said, it can be changed using the event if people don’t like it |
morbus (they/them) |
Sure, but you’re not the one and only. You’re just a plug-in to something else. |
mglaman |
The Commerce API module won’t be treated that way, it’s considered an end solution |
mglaman |
I can only deal with Drupalisms for so long |
mglaman |
We’ll see when it comes out. |
morbus (they/them) |
I can see lack of namespaces in compiled frontenfs where everything is linted and compressed to nothing, but that’s not my use case (no front end here). I would have stuck with Drupalisms. Ah well. Not a biggie. |
mglaman |
@morbus (they/them) :thinking_face: maybe we can add a kill switch to turn off those assumptions |
mglaman |
like a service parameter? “Hey, don’t mess with my resource types” |
mglaman |
or you remove the event subscriber which does the transformations |
e0ipso |
@morbus (they/them) is there any public place to take a look at the default content functionality? |
mglaman |
so it’s not uber permanent |
morbus (they/them) |
I’ve already got Extras installed. If I can just rename em there, we’re all good. |
mglaman |
(totally hijacked this thread :grimacing: ) |
morbus (they/them) |
@e0ipso not yet but I still have a note to write a medium about it something. |
morbus (they/them) |
Along with another note to ping you about it. |
mglaman |
@morbus (they/them) appreciate your input on the resource renaming |
morbus (they/them) |
Why’d you go from singular commerce_product to plural products? |
gabesullice |
please start convo :three: :wink: |
mglaman |
So we removed all commerce_ prefixes. And a common API pattern is to use pluralization in endpoints |
mglaman |
I have to go now though :upside_down_face: @morbus (they/them) feel free to catalog some Qs and I’ll reply |
morbus (they/them) |
But... now you’ve got competing Drupal core and Commerce. Plurals and singulars mixed. |
morbus (they/them) |
The “we are the one and only” is frustrating. |
mglaman |
There’s reasons and they’ll come out |
mglaman |
It’s a simple “undo” if people don’t want it |
mglaman |
I have to go though. |
Comments
Comment #11
gabesulliceGranting credit.
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedThese minutes look complete to me and credit has been given. Closing as fixed. If this is incorrect, reopen and leave a comment. Thx.