Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: https://www.drupal.org/project/drupal/issues/3105364
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
9:07
0️⃣ Who is here today?
| heddn | heddn here |
| damienmckenna | Damien. Anyone have a spare snow shovel? |
| quietone | Me too |
| Gábor Hojtsy (he/him) | Me |
| dinarcon | Me :wave: |
| Nick Wilde (he/him) - DC 2020 DevOps Session Team | sooorta here |
| alison | Heeeeeeere!! Finally!!!!! |
| (anonymous) | Comment Redacted |
| wimleers (he/him) | :wave: Wim, belated, because meeeeetings |
1️⃣ What do we need to talk about?
| damienmckenna | Are any of these 9.0.0-beta1 blockers? |
| quietone | I'd like to see this blocker committed, #3024682: Migrate UI - add human-friendly module names to the Review form. |
| alison | (might not be appropriate for meeting, idk) Suggestions/Advice/Recs/whatever for how to help review migration issues when you don't personally have an active migration project? -- like, what do y'all do, or do you always have active migration projects? (in which case, color me jealous)I haven't been helping out since my migration project ended, and I'd like to help, but I'm not sure how to help out -- I could "reboot" the project I was working on before I guess, that could work, but I'm wondering if y'all have any suggestions / if there's something Everyone Is Doing that I'm not aware of (since, for example, Simplytest isn't a good option for this kind of thing -- AFAIK). |
| quietone | @alison Nearly all of my work on migration in core has been done using the test fixtures as a source. |
| quietone | @alison DM? |
2️⃣ Drupal 9 deprecated code removal
| mikelutz | #3110315: Remove all @deprecated code from migrate_drupal module |
| Gábor Hojtsy (he/him) | ^^^ this one is currently RTBC but if there are complaints, file them there |
| Gábor Hojtsy (he/him) | #3111373: Remove deprecated migrate plugins from non-migrate modules is the second one, also currently RTBC, I don’t think it is contentious, but would be great to confirm :slightly_smiling_face: |
| Gábor Hojtsy (he/him) | finally #3111344: Remove deprecated code from migrate module is green but not yet RTBC, we need to agree on how to deal with the removal of support for migration templates |
| Gábor Hojtsy (he/him) | These 3 would remove all the deprecated code from migrate modules and other modules’ migrate related code as they are now. |
| Gábor Hojtsy (he/him) | Looks like 2 of them landed already :smile: |
| wimleers (he/him) | Nice! |
3️⃣ getHighestId() should be able to use any integer destination id
| mikelutz | #3091004: getHighestId() should be able to use any integer destination id |
4️⃣ Skip_on_empty doesn’t work after a failed migration lookup with multiple destination ids
| mikelutz | #3095270: Sql Migration map returns nonsensical destination ids when looking up against a source id row that failed or was ignored. |
| Nick Wilde (he/him) - DC 2020 DevOps Session Team | RTBC'd |
5️⃣ Add missing test of field option translations for booleans
| mikelutz | #3103031: Add bundle to the sourceIDs to FieldOptionTranslation source plugin |
| quietone | assigned to myself to respond to feedback |
6️⃣ Implement Entity::fields() for migration destinations
| mikelutz | #2630732: Implement Entity::fields() for migration destinations |
7️⃣ Allow logging for non-strings values.
| mikelutz | #3047328: Allow logging for non-strings values |
8️⃣ The Drupal 7 ThemeSettings source plugin does not check that the destination site has a valid theme to migrate settings into
| mikelutz | #3096972: The Drupal 7 ThemeSettings source plugin does not check that the destination site has a valid theme to migrate settings into |
| quietone | I've looked at this a few time and it looks good. I just don't know enough about themes to provide a thorough review.@mikelutz , @heddn can either of you confirm the approach here? |
| heddn | I am a little worried about the BC implications in the destination plugin. It could be it isn't a problem, but then again... these things are tricky and it might be an issue. Bumped back to NW for another look. @wimleers (he/him) |
| wimleers (he/him) | Will review again at some point in the future. |
9️⃣ Create a way to declare a plugin ID defined in a migration yml file as deprecated
| mikelutz | #3039240: Create a way to declare a plugin as deprecated |
| wimleers (he/him) | Still :neutral_face: |
🔟 Field formatter & widget settings: fall back to default if missing plugin
| mikelutz | #3108302: [PP-2] Field formatter & widget settings: fall back to default if missing plugin |
| wimleers (he/him) | REAAAAAAAAAAAAAALLLLY looking forward to feedback here from @mikelutz, @quietone & @heddn :slightly_smiling_face: :slightly_smiling_face: (edited) |
| wimleers (he/him) | @huzooka did all the work on this one! |
1️⃣ :one: Migrate D7 entity translation revision translations to D8
| mikelutz | #2746541: Migrate D6 and D7 node revision translations to D8 |
| mikelutz | #3076447: Migrate D7 entity translation revision translations |
| quietone | The node revision has had an extensive cleanup, thanks to reviews by wim leers. It would help to have more eyes on it. |
| quietone | A couple of points to double checkThe complete (new name for master) node migration will run from the UI unless there is an existing map table with rows.From drush both complete and classic migrations are available. It is up to the developer to decide which to use. |
| quietone | @mikelutz @heddn @Gábor Hojtsy (he/him) Do you agree with the points above? |
| Gábor Hojtsy (he/him) | @quietone they sound sensible, that said I did 0 migrations, so I would not be the best to ask :smile: |
| Gábor Hojtsy (he/him) | it would be amazing if it looks good then @mikelutz and/or @wimleers (he/him) can RTBC :slightly_smiling_face: then we can move on to the entity translation one |
| wimleers (he/him) | I should :fingerscrossed: be able to review again next week. But the hard blocker is @mikelutz agreeing on the rename + using the new one always. |
1️⃣ 2️⃣ Migrate empty, and link field
| mikelutz | #3110064: Migrate empty, <nolink> and <none> link field |
1️⃣ 3️⃣ Plugin migration_lookup don’t process source when part of plugin sub_process
| mikelutz | #2915717: Plugin migration_lookup don't process source when part of plugin sub_process |
1️⃣ 4️⃣ Move actions migrations and tests to system module
| mikelutz | #3067299: Move actions migrations and tests to system module |
1️⃣ 5️⃣ Migration Lookup plugin does not return multiple values when matched
| mikelutz | #2890844: Migration Lookup plugin does not return multiple values when matched |
1️⃣ 6️⃣ If no Drupal 8 equivalent filter is found during migration, drop transformation-only filters, so that body fields show up
| mikelutz | #3061571: If no Drupal 8 equivalent filter is found during migration, drop transformation-only filters, so that body fields show up |
| wimleers (he/him) | REAAAAAAAAAAAAAAAAALLY looking forward to reviews on this one too from @mikelutz, @heddn and @quietone! |
| huzooka | :slightly_smiling_face: |
Participants:
heddn, damienmckenna, quietone, Gábor Hojtsy (he/him), dinarcon, Nick Wilde (he/him) - DC 2020 DevOps Session Team, alison, wimleers (he/him), mikelutz, huzooka
Comments
Comment #3
mikelutzComment #5
mikelutzComment #7
mikelutzComment #9
mikelutzComment #11
mikelutzComment #13
mikelutzComment #15
mikelutzComment #17
mikelutzComment #19
mikelutz