Do it.

CommentFileSizeAuthor
#9 3110315-9.patch11.34 KBgábor hojtsy
#7 3110315-7.patch9.99 KBandypost
#5 interdiff-3110315-2-5.txt2.29 KBhardik_patel_12
#5 3110315-5.patch13.66 KBhardik_patel_12
#2 3110315-2.patch15.14 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3110315-2.patch15.14 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
Parent issue: #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch »
hardik_patel_12’s picture

hardik_patel_12 commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3110315-5.patch13.66 KB
new interdiff-3110315-2-5.txt2.29 KB

Kindly review a new patch.

quietone’s picture

quietone commented
Status: Needs review » Needs work

Changing to NW since the patch doesn't apply cleanly.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 3110315-7.patch9.99 KB

Rer-roll, i18n vars gone, but the remaining deprecated trigger is https://www.drupal.org/node/2929443 inside of \Drupal\migrate_drupal\MigrationState::buildUpgradeState()
Probably it should use assert() or logger

The test for removal deprecated in #3109746-8: Remove remaining @deprecated code in the datetime module

Status: Needs review » Needs work

The last submitted patch, 7: 3110315-7.patch, failed testing. View results

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3110315-9.patch11.34 KB

Merged with #3109746: Remove remaining @deprecated code in the datetime module, since that is testing the code being removed here. Removing the test ahead of removing the code being tested did not look like a good step.

Gábor Hojtsy credited longwave.

Gábor Hojtsy credited mpdonadio.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Carry over contributor credits from there.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I agree that better close as duplicate, and there's no more leftovers in the module

PS: looks no needs to transfer credits from the closed issue and interdiff between #7 and #9 exactly is #3109746-5: Remove remaining @deprecated code in the datetime module

  • catch committed 529c16e on 9.0.x 
    Issue #3110315 by Hardik_Patel_12, Gábor Hojtsy, andypost, longwave,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 529c16e and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.