Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.All deprecated code were removed in #3091528: Remove deprecated code from datetime module but this remains makes sense to remove as well
The remaining deprecated test for method \Drupal\migrate_drupal\Plugin\migrate\field\FieldPluginBase::processFieldValues() could be fixed in #3110315: Remove all @deprecated code from migrate_drupal module but it's not related to migrate_drupal module
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff-3109746-2-5.txt | 3.38 KB | hardik_patel_12 |
| #5 | 3109746-5.patch | 1.35 KB | hardik_patel_12 |
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #4
longwaveThe whole DateFieldLegacyTest class can be deleted here.
However, this is really about removing deprecated code from migrate_drupal, only the test is in datetime. Maybe we should remove all deprecations from that module in this issue?
Comment #5
hardik_patel_12 commentedKindly review a new patch.
For this i have seen there are many deprecated code is still present in migrate_drupal module and it is not related to datetime module, So i think it's better to not remove all deprecations in this issue. We can handle all deprecations from migrate_drupal module in new issue.
Comment #6
hardik_patel_12 commentedComment #7
mpdonadio#5, this is one of the weird things with datetime.module and datetime_range.module. They define fields, where all other(?) are define in core proper. So, the datetime related migration code is in the module, since you can't do those migrations w/o the module being enabled. DateFieldLegacyTest is part of the migrate @group and not datetime, so I think this should be part of that cleanup.
Comment #8
andypostUpdated IS with state
I think it fine to remove remains here instead of #3110315: Remove all @deprecated code from migrate_drupal module
Comment #9
andypostComment #10
gábor hojtsyI think this should be done as part of #3110315: Remove all @deprecated code from migrate_drupal module honestly, that patch fails without this landing, so removing the use and the API all at once would be better than removing the test and then removing the code being tested at some other place. They should be removed at once.