Migrate D7 entity translation revision translations

Added an english and icelandic revision.

Correct the tags

Ignore previous patch. How about this one which adds a new content type which uses entity translation and has some revisions.

Good idea but I've noticed something since then about this patch. When using the test fixture and adding entity translation revisions the db table entity_translation_revision is not populated. But if I do the same with a fresh d7 site, the entity_translation_revision table is populated. That is a bit of a worry to me.

Well, here is yet another approach. This uses a new fixture just for entity translation as that is the only way I could get have an 'entity_translation_revision' table. Hopefully I've made the correct changed to drupaci.yml (as was done in #2746541: Migrate D6 and D7 node revision translations to D8 by mikelutz so this just runs the new tests.

I am having a problem with the dates though and the test will fail.

Those are the errors I expected. And I see that there are coding standard errors, due to comment out code in D7NodeDeriver, that needs to be fixed.

The method used here is based on the node master approach used in #2746541: Migrate D6 and D7 node revision translations to D8, the only difference is that the source plugin uses the entity_translation_revision table. I did try locally once without the node master approach and it didn't work, having the same sort of problems encountered in the node translation revision issue.

Still to do is to sort out the revision tabs, migrated changed dates and then to get this approach working with the whole system.

Removed test code. Removed translation tag from the migration. Change the migration to use the dates from the entity_translation_revision table and added a process plugin in an attempt to get the revision translation affected flag correct. Need to review again.

This is a different approach. This uses the NodeMaster source plugin and destination that are used in #2746541: Migrate D6 and D7 node revision translations to D8. The changes here are to the source plugin, a test fixture that uses entity translation and node translation and of course the migration test itself. The test is failing because of some changed dated fields are being set to the current time and the field value for the field, field_tree, is wrong. The correct field data is migrated so I guess I've mucked up the test.

edit:

local testing with drush shows that the revision tabs look correct. Of course, that needs manual testing by someone else as well.

Wow that is a bad patch. Need to redo it.

Let's try that again. And now with a review patch that excludes the test fixture.

Some cleanup and adding comments.
the difference between this is and #2746541: Migrate D6 and D7 node revision translations to D8 is that there are no d6 files here, or course, the addition of querying the entity_translation_revision table in the node_master source plugin, a process plugin to help determine the revision_translation_affected property and the new source fixture.

Rebuilding this ontop of the latest patch in the node translation issue. Created MigrateNodeMasterETTest just to test with the drupal7 fixture that has entity translation revision. Also, changing it to run all the test so I expect there will be many.

Fix the ordering in the query. Still just a test patch.

Add a test in prepareRow to drop rows that are not the one changed in this revision. The test assumes that the row with the latest changed timestamp in the entity_translation_revision table is the one that has been edited. And it is only this row that is migrated.

I'd like to think that this can be done in the query() method but I wasn't successful in making a subquery in Drupal. Maybe someone else can have a look.

What is not working is the migration of the translated field on the entity.

Needs a reroll.

Now merge in 2746541-231.patch from the node translation revision issue.

Created an entity_translation_revision table for the test fixture drupal7.php and that changed the migrated times. Also, made a todo for looking to the migration of the a field.

@Wim Leers, The first paragraph in #33 is correct. This will use the same approach as in #2746541: Migrate D6 and D7 node revision translations to D8.

I working on rerolling this now.

This is a partial reroll and best if you just ignore it. The drupal7 test fixture here should be the same as the one in #2746541: Migrate D6 and D7 node revision translations to D8 which means it is missing changes needed here.

Another increment on this reroll. Working towards a patch that is base on the node revision translation one but has the additions to the complete node source plugin. This still does not have the changes to the drupal7 fixture.

I'm not convinced an interdiff will be of much use. The patch in #28 is based on an older version of the node revision translation patch and there is a lot that is no longer relevant.

Twice I forgot to change the version.

Fixing the failing test and including a diff against the patch in #28 if anyone is interested. The key piece that is missing is the addition of the entity translation revision table in the d7 fixture. I've done that locally and tests are failing so still work to do.

Just keeping in sync with the changes in #2746541: Migrate D6 and D7 node revision translations to D8.

Let me try that again.

Adjust the entity counts.

Reexamined the entity translation test fixture and corrected MigrateNodeCompleteETTest.php accordingly.

Oops, somehow lost the changes to drupal7.php. This restores that and adjusts the times for node 1 in the test.

Messed up the drupal7 fixture again. Try again.

This patch removes the test fixture, drupal7_et.php, which was a temporary tool for testing. The node with entity translation and it s field, field_tree, is now incorporated into the drupal7.php fixture.

This includes the patch from #380 from the node revision patch, #2746541: Migrate D6 and D7 node revision translations to D8.

Alter tests to take account of changes to the fixture.

Aborted that because I left a note to myself in the code.

Update the IS.

Fixing more tests.

Update entity count.

correct number of field_config entities.

And some more entity counts/

This is ready for testing.

Update the node for testers in the IS.

A reroll of #64 since #2746541: Migrate D6 and D7 node revision translations to D8 was committed. The diff is largely unhelpful because the patch from #64 included the work from the node revision issue and this reroll just removes all that.

The commented out lines were something that needed to be fixed. And here is the fix whichi is just to test the revision creation time. And also improve a comment

@Wim Leers, yes. A thorough review.

A 9.1.x version of the patch, I made this from the patch in #72.

You are right, this is specific to the entity translation revisions for node and node only.

This patch introduces the first use of the entity_translation_revision table. The existing entity translation migrations for comment, taxonomy and user all use the entity_translation table. Why not the revision table? Not being familiar with entity translation for those entities I just did some testing and it is sufficient since they are not revision-able. Unless, of course, my testing was inadequate.

d7_comment_entity_translation.yml
d7_taxonomy_term_entity_translation.yml
d7_user_entity_translation.yml

Rerolled for 8.9 and 9.0. It is late and I am rather tired so I hope Upgrade7Test will pass, that was the only one with a conflict.

Oh, the diff for both is against the 9.1.x version from #82.

@catch, thanks.

This serves as a good reminder to test the migration patches with PostgreSQL and SQLlite before RTBC.

@daffie, thanks for making the patch and to catch and xjm for getting this one in.