Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: https://www.drupal.org/project/drupal/issues/3136544
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
0️⃣ Who is here today?
| benjifisher |
Benji Fisher. I mostly help by reviewing @quietone's patches. |
| quietone |
I'm am here and yawning |
| phenaproxima (he/him) |
:wave: |
| Nick Dickinson Wilde |
how is it meeting time already?! |
| phenaproxima (he/him) |
No idea. |
| alison |
Hi! |
| damienmckenna |
:wave: |
| heddn |
:wave: |
| wimleers (he/him) |
:wave: |
1️⃣ What do we need to talk about? We’ll triage the NR queue, what else?
| benjifisher |
Documentation: List of core Migrate process plugins at https://www.drupal.org/docs/8/api/migrate-api/migrate-process-plugins/li... |
| benjifisher |
#2746541: Migrate D6 and D7 node revision translations to D8 is RTBC. If you add a thread for it, then I will give a status update. |
| damienmckenna |
On the Metatag I've been using some time from my weekly Contrib Half Hour meetings to document the amazing work lots of folks here did on the D6 and D7 migration paths. Today am going to use that documentation to then help plot out extra test coverage needed for the Field Collections to Paragraphs migration, which currently doesn't have much coverage. So, where would be the best place to turn comments from an issue into official documentation on how to build migration solutions for contrib modules? (edited) |
| benjifisher |
@damienmckenna have you been working with Wim Leers on that? I think he asked about those issues in this channel a day or two ago. |
| damienmckenna |
I haven't been keeping up on the channel lately. |
| damienmckenna |
Found it, thanks for the tip Benji! |
2️⃣ Migrate d7 menu translation
3️⃣ \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated
4️⃣ Migrations fail due to missing dependency when dependency is clearly not missing.
5️⃣ Migrate process plugin documentation
| mikelutz |
https://www.drupal.org/docs/8/api/migrate-api/migrate-process-plugins/li... |
| benjifisher |
This page lists the process plugins in the core migrate module and has a link to the page of process plugins in the contrib Migrate Plus module.If we want to be consistent with the title, I think we shouldMove the link from the body of the page to the Related content section (currently empty).While we are at it, do the same for the link to "Writing a custom process plugin".Add links to the API docs of process plugins provided by other core modules. |
| benjifisher |
If I get a :+1: from one or two of the Migrate maintainers, then I will stop asking about this at meetings and add it to my todo list. |
| quietone |
I was just about to type. Yes, a good idea! |
| alison |
Great plan! |
6️⃣ [backport] Migrate D6 and D7 node revision translations to D8
| mikelutz |
#2746541: Migrate D6 and D7 node revision translations to D8 |
| quietone |
The patch is there and passing tests, just waiting on release managers to respond. |
| benjifisher |
This has already been fixed in 8.9.x, 9.0.x, 9.1.x. Everyone agrees that we should try to get it committed to a patch release of 8.8."Everyone" includes Catch. It is in his hands, and he does not need any reminders.There was a late change: at Catch's suggestion, and with Lucas's :+1:, we updated settings.php so that classic node migrations (as opposed to complete) are the default in 8.8. |
| benjifisher |
I notice that there was not a patch release of 8.8 yesterday. It may be that this is one of the issues holding it up. |
| benjifisher |
I also raised a question about how that issue affects the test coverage for classic node migrations. |
7️⃣ Automatically derive auxiliary migrations
8️⃣ Call to a member function getSetting() on null in Drupal\migrate_drupal\Plugin\migrate\EntityReferenceTranslationDeriver->getDerivativeDefinitions()
9️⃣ Allow logging for non-strings values
🔟 Move memory management from MigrateExecutable to an event subscriber
1️⃣ :one: Migrate D7 entity translation revision translations to D8
| mikelutz |
#3076447: Migrate D7 entity translation revision translations |
| benjifisher |
Maybe it is time to change the title of this issue to reference D9. |
| quietone |
this builds on the node complete migrations and is much small and easier to follow. |
| quietone |
It is ready for manual testing as well. |
| quietone |
Title changed, just removed 'to D8' |
1️⃣ 2️⃣ Refactor and document the MenuLinkParent process plugin
| mikelutz |
#2845485: Refactor and document the MenuLinkParent process plugin |
| quietone |
There is one patch in the logic I haven't been able to create a test for. That is when the url->isRouted() is true. If you know how please comment in the issue |
| mikelutz |
commented. |
| alison |
awesome issue / functionality improvementdocumentation in the code looks good, too (edited) |
1️⃣ 3️⃣ Make every migrate process plugin that provides ‘default_value’ be able to correctly handle ‘NULL’ default values
| mikelutz |
#3133516: Make every migrate process plugin that provides 'default_value' be able to correctly handle 'NULL' default values |
| quietone |
@phenaproxima (he/him) why don't you like having extract wrap around the default value plugin? |
| phenaproxima (he/him) |
Well, I don’t dislike it |
| phenaproxima (he/him) |
It just feels a little weird, because it’s more overhead than, IMHO, a simple $this->configuration += ['default' => NULL]. |
| phenaproxima (he/him) |
Like, why not let extract just return NULL as a default value? |
| mikelutz |
I just commented that I’m opposed too. Plugins shouldn’t be instantiated outside of their plugin manager. (edited) |
| mikelutz |
Can we not just change the isset check to an array_key_exists check and call it a day? |
| mikelutz |
I consider that a bugfix and not a BC regression. |
| quietone |
OK |
| phenaproxima (he/him) |
I’m open to having the plugins wrapped, but array_key_exists() seems like a simple, clean check that is not a BC break. |
| phenaproxima (he/him) |
So I feel like I’d need a more compelling reason to wrap it. As it is now, we’re just codifying a workaround. |
| mikelutz |
I mean, you have to change the check anyway, to determine if you need to wrap it or not. so I think we can avoid the wrap as redundant. |
| wimleers (he/him) |
YAY progress here! |
@mikelutz thanks for facilitating
Goodnight, @quietone Thanks for staying up so late. :slightly_smiling_face: (edited)
1️⃣ 4️⃣ . That’s our time. We didn’t get through the entire NR queue, but we resolved or sent back for work quite a few old issues today and cut the list in half. If there is another issue near and dear to your heart that we didn’t get too, feel free to ask for reviews in this channel anytime, no need to wait for a meeting. Thanks to everybody that participated, this has been a very productive meeting. :slightly_smiling_face:
Participants:
benjifisher, quietone, phenaproxima (he/him), Nick Dickinson Wilde, alison, damienmckenna, heddn, wimleers (he/him), mikelutz
Comments
Comment #2
benjifisherOops, I got the date wrong in the issue title.
Comment #3
mikelutzComment #11
benjifisherComment #12
benjifisher