When garbage collection successfully deleted a temporary file, It should log a message for the admin to aware of.
Also sort the query by "changed" field in DESC (Descending order), this will help to eliminate a situation when a large amount of files to delete and the delete process can't process the newest temporary files. This change will start the delete process from the newest temporary file.
Comment | File | Size | Author |
---|---|---|---|
#15 | 3061640-15.patch | 524 bytes | ranjith_kumar_k_u |
| |||
#14 | 3061640-nr-bot.txt | 144 bytes | needs-review-queue-bot |
#11 | interdiff-10_11.txt | 537 bytes | Gauravvvv |
#11 | 3061640-11.patch | 503 bytes | Gauravvvv |
#10 | 3061640-9.patch | 506 bytes | ranjith_kumar_k_u |
Comments
Comment #2
finaukaufusi CreditAttribution: finaukaufusi as a volunteer commentedComment #3
cilefen CreditAttribution: cilefen at Institute for Advanced Study commentedComment #9
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented.
Comment #10
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commentedRe-rolled #2 for 9.4. The log message code is already there, I just added the sort condition.
Comment #11
Gauravvvv CreditAttribution: Gauravvvv at Srijan | A Material+ Company for Drupal India Association commentedFixed phpcs issue, Attached interdiff for same. Please review.
Comment #14
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #15
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedRe-rolled #11
error: patch failed: core/modules/file/file.module:650
error: core/modules/file/file.module: patch does not apply
Comment #16
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #17
smustgrave CreditAttribution: smustgrave at Mobomo commentedEven though this is a task it seems like it will need test coverage.
Comment #18
Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commentedUpdating attributions