Problem/Motivation

DO NOT COMMIT
Until #3031639: [PP-1] Relax composer.json requirements to allow Drupal 8 to be installed with Twig 2 and #2976407: Use drupalci.yml for composer dependency min/max testing - DO NOT COMMIT are resolved, we don't have automated testing to ensure that Drupal 8 keeps being compatible with Twig 2. This issue can be retested to do regression testing in the meantime.

Proposed resolution

Run manually as needed. Automate it in the respective issues mentioned above :)

Remaining tasks

Run manually as needed. Automate it in the respective issues mentioned above :)

User interface changes

None.

API changes

None. Drupal 8 is already Twig 2 compatible.

Data model changes

None.

Release notes snippet

N/A.

CommentFileSizeAuthor
#20 3032695-13.patch2.31 KBGábor Hojtsy
#13 3032695-13.patch2.31 KBjibran
#2 3032695.patch2.46 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
FileSize
3032695.patch2.46 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: Manually test Drupal 8 with Twig 2 » [NO COMMIT] Manually test Drupal 8 with Twig 2
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Or we can set it RTBC and bot can pick it up automatically.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

That is not a bad idea :D

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Parent issue: » #2568181: [META] Update to Twig 2.x in Drupal 9
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Can we recategorize as a support request to make this easier to filter out of the RTBC list?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Category: Task » Support request

Yeah it does not matter as long as the RTBC retesting happens either way I guess :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3032695.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3032695.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: [NO COMMIT] Manually test Drupal 8 with Twig 2 » Update twig/twig to 2.x for 8.8.x and drop twig/twig 1.x support
Category: Support request » Task
Status: Reviewed & tested by the community » Needs review
Related issues: +#3008870: Drop support for PHPUnit 4.8 once PHP 5 is no longer supported (8.8.x), +#3039611: Update core PHP dependencies for 8.8.x
FileSize
3032695-13.patch2.31 KB

I think we can do this now in 8.8.x because it is same as #3008870: Drop support for PHPUnit 4.8 once PHP 5 is no longer supported (8.8.x).

composer update twig/twig
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating twig/twig (v1.38.2 => v2.7.2): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.
Writing lock file
Generating optimized autoload files
> Drupal\Core\Composer\Composer::preAutoloadDump
> Drupal\Core\Composer\Composer::ensureHtaccess
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Issue summary: View changes

From https://groups.drupal.org/node/518200:

Once 8.8.x is opened, the library dependencies in that branch can be updated to versions that have a PHP 7.0 requirement, and the Drupal code itself in that branch can begin relying on PHP 7 features.

Status: Needs review » Needs work

The last submitted patch, 13: 3032695-13.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: Update twig/twig to 2.x for 8.8.x and drop twig/twig 1.x support » [NO COMMIT] Manually test Drupal 8 with Twig 2
Status: Needs review » Needs work

After discussing with @Gábor Hojtsy reverting back the issue:

No Twig 2 is not backwards compatible with twig 1 so it cannot be a required part of Drupal 8.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Category: Task » Support request
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: [NO COMMIT] Manually test Drupal 8 with Twig 2 » [PP-1] [NO COMMIT] Manually test Drupal 8 with Twig 2
Status: Needs work » Postponed

Created #3041076: Update Drupal 9 to Twig 2, postponing on that now. Since the goal of this issue to serve as a test to prove it works, and it does not work, we should resolve that it does not work and then come back to continue run this.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: [PP-1] [NO COMMIT] Manually test Drupal 8 with Twig 2 » Update Drupal 9 to Twig 2
Version: 8.9.x-dev » 9.0.x-dev
Category: Support request » Task
Status: Postponed » Needs review
FileSize
3032695-13.patch2.31 KB

Let's get the testing going on this again. Uploading @jibran's #13 again.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Update Drupal 9 to Twig 2 » Manually test Drupal 8 with Twig 2
Status: Needs review » Closed (duplicate)

Actually closing in favour of #3041076: Update Drupal 9 to Twig 2 which not only updates twig but also fixes the test fails this issue would introduce. Now in Drupal 9 they need to be done at once, so the separation of the two issues don't make sense anymore AFAIS. Will move credits over. Restoring title to avoid confusion later.