Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While I was testing another patch I had to switch off css aggregation. Then I noticed an error in the broser console
Refused to apply style from 'http://umami.lndo.site/core/profiles/demo_umami/themes/umami/css/compone...' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
Further investigation let to the conclusion that this file is missing.
If not needed, proposed solution would be to remove this file from the umami.library.yml
Comment | File | Size | Author |
---|---|---|---|
#2 | no article.css is used-3001893-02.patch | 671 bytes | parijke |
Comments
Comment #2
parijke CreditAttribution: parijke as a volunteer commentedhere's a mini patch if not needed
Comment #3
parijke CreditAttribution: parijke as a volunteer commentedComment #4
Eli-TLooks like this was deliberately removed in http://cgit.drupalcode.org/drupal/commit/?id=9949db9f0581806185cc90b96eb... but not from the library
Comment #5
googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commentedGood catch
Comment #6
parijke CreditAttribution: parijke as a volunteer commentedAll other files mentioned in umami.library.yml sre actually there, so article.css is the only one missing
Comment #7
longwaveI wonder if it is worth adding a warning message to core if it detects a missing file declared in a theme (or module, I guess).
Comment #8
googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commentedRe #7 If we want to do so, that should be a separate issue. Don't think this is a general issue though so not sure if that would be worth it.
Comment #9
Eli-T+1 for not doing that in this issue
Comment #10
longwaveOh sure, I wasn't suggesting doing it here, just that if people think it is worthwhile we could open a new issue, as if we can make this mistake in a core theme I am sure it has happened in contrib/custom themes as well.
Comment #11
lauriiiComment #13
lauriiiCommitted d938a14 and pushed to 8.7.x. Also cherry-picked to 8.6.x. Thanks! 🚀