MenuLinkContent's "menu_name" base field is a string field rather than an entity reference field

Has been added.

Hi,

Here is the rerolled patch.

Thanks
Mrinalini

We need to add hook_update_N to install new FieldStorageDefinition in #14.

Re-rolling #15 with test case issue fix.

I will create the patch passing the test cases.

Re-rolling #19 with test case issue fix.

+++ b/core/modules/menu_link_content/src/Entity/MenuLinkContent.php
@@ -80,6 +81,14 @@ public function setInsidePlugin() {
+    $this->set('menu', $menu->id());

We are adding a new column menu in the menu_link_content table while the menu_name is already there for the same purpose. This is a redundancy.

Also, the description given for the field is a little bit confusing.

Shouldn't we modify the existing field or remove the existing if we are trying to use a new one.

Test cases are getting failed because we are adding a reference field but not passing the value of this in test cases. We should pass the menu in test cases.

In core/modules/menu_link_content/tests/src/Kernel/MenuLinksTest.php

public function testPendingRevisions() {
    /** @var \Drupal\Core\Entity\RevisionableStorageInterface $storage */
    $storage = \Drupal::entityTypeManager()->getStorage('menu_link_content');

    // Add new menu items in a hierarchy.
    $default_root_1_title = $this->randomMachineName(8);
    $root_1 = $storage->create([
      'title' => $default_root_1_title,
      'link' => [['uri' => 'internal:/#root_1']],
      'menu_name' => 'menu_test', <strong> // We should add a new entry for menu here.</strong>
    ]);

The existing menu_name field may be used in some other places as well as in core and contributed both. So we can't remove the field directly. We need to have a plan to use/remove this.

Removing Needs reroll tag as patch #22 (menu-name-is-a-string-field-2984224-22.patch) is working fine with the current core version.

Discussed in #bugsmash with larowlan. I agree with him that this is not bug and is either a task or feature request. I think task is a better fit and keeping at major.