Steps to reproduce:
1. Install Drupal 8.5.x (8.5.1 in this case, was working fine before 8.5)
2. enable Language, Content Translation, Content Moderation, and Workflows modules
3. add another language, like French
3. enable content translation on Basic Pages
4. add Default Comment field to Basic Pages (not via "Existing Fields")
5. add the Editorial workflow to Basic Pages
5. create an English Basic Page
6. translate that Basic Page and try to save

Expected behavior:
The node saves.

Current behavior:
You get an error saying "Non-translatable fields can only be changed when updating the original language."

Current Work-around:
Edit Baic Page Comment field and check the "Users may translate this field" checkbox. Now your Translation will save.

Issues:
* The error is not very clear and if your dealing with more than a few fields (like 50) this can take quite a while to debug
* Doing the above steps in a different order (say adding the comment field first, then enabling translation, or adding the existing Comment field) will not trigger the error as the checkbox get automatically ticked when following this order

Proposed Solutions:
(a) remove the "Users may translate this field requirement" for comment fields. After all, what does it mean that users can translate this field? It is not the ability to translate comments, or field meta-data like title and description. This field merely binds a type of comment to a type of node, right?
(b) Have a better error message telling users what field is the offender in the error message (or in Drupal logs)

Comments

NickGee created an issue. See original summary.

nickgee’s picture

Issue summary: View changes
nickgee’s picture

Follow up:

It turns out that checking the "Users may translate this field" has a few consequences:

  1. the comment open / closed status does not sync anymore
  2. the comment counts are not synced anymore (ie. 4 comments on the EN "node", 0 on the FR "node")
  3. submitting comments on the FR "node" (which is open for comment) gives the following error (in French) : "Comment: unauthorized comment submitted or comment submitted to a closed post %subject."

Some thoughts on these:

  1. this is obvious, but does not adhere to our business needs, unfortunately
  2. this is unfortunate too and kind of doesn't sit well with the idea that nodes are entities and entities have translations. This should mean that all comments should be counted for an entity, regardless of whether it's viewed in EN or FR
  3. this just seems like a bug and does not fit in with 1 and 2 above

I would also just add that this started with the 8.5 update.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pavlosdan’s picture

This looks like the same issue as I observed here: #3025039: New non translatable field on translatable content throws error since this one is older, I'll close that as a duplicate.

detroz’s picture

Hi,

The deep problem of this issue looks like an issue of "Paragraphs" module #3004099: Allow to translate paragraphs from pending revisions.
As the patch suggested is on the core, a core issue exists too : #3015480: Allow skipping translation check at field level for non-translatable fields

Regards,
Detroz

dmitry.korhov’s picture

Issue is reproducible even if comment module is uninstalled

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

sanjayk’s picture

Assigned: Unassigned » sanjayk

While testing https://www.drupal.org/project/drupal/issues/3025039#comment-13658647 and apply patch #16 still get the same error "Non-translatable fields can only be changed when updating the original language."

sanjayk’s picture

Assigned: sanjayk » Unassigned

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

deepak goyal’s picture

Status: Active » Needs work

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
nickgee’s picture

lendude’s picture

Status: Needs work » Closed (duplicate)
Issue tags: +Bug Smash Initiative

I'm going to close this as a duplicate of either #3025039: New non translatable field on translatable content throws error or #3015675: Translations of nodes with comment settings field set to non-translatable returns EntityUntranslatableFieldsConstraint, both those issues are newer but both contain possible fixes and automated test, so I suggest continuing the work there.

If you feel this is addressing a different issue than either of those issue, feel free to re-open this issue.