Hi,

when "Content" language negotiation is enabled the links in the interface language switcher are broken, in particular they never allow to change the interface language (see also #2860901: Doubts about Content language negotiation).

Look at the images below:

LanguageNegotiationContentEntity breaks interface language switcher with no query string

LanguageNegotiationContentEntity breaks interface language switcher with query string

This is because LanguageNegotiationContentEntity::processOutbound() unsets $options['language'] and this means that the current url language prefix would be forced in the generated links, as stated in Url::fromUri under "Parameters", array $options, 'language'.

A way to fix this could be to mark in some way that the URLs come from another language switcher, and in that case leave them alone.

A "proof of concept" patch is on its way.

Thanks,
Antonio

CommentFileSizeAuthor
#18 2864055-nr-bot.txt230 bytesneeds-review-queue-bot
#14 core-language_negotiation_content_entity_dont_break_interface_language_switcher_links-2864055-14.patch3.51 KBjames.williams
#13 language_negotiation_content_entity_dont_break_interface_language_switcher_links-2864055-13.patch.patch3.58 KBvredko
#7 interdiff-4-7.txt4.18 KBmarcoscano
#7 2864055-7.patch6.95 KBmarcoscano
#7 2864055-test-only-FAIL.patch3.45 KBmarcoscano
#4 interdiff-2864055-2-4-do-not-test.diff1.97 KBao2
#4 LanguageNegotiationContentEntity_dont_break_interface_language_switcher_links-2864055-4.patch3.2 KBao2
#2 LanguageNegotiationContentEntity_dont_break_interface_language_switcher_links-2864055-2.patch3.11 KBao2
#2 content_language_negotiation_processOutboud_with_query_string_after.png87.1 KBao2
#2 content_language_negotiation_processOutboud_no_query_string_after.png91.17 KBao2
content_language_negotiation_processOutboud_with_query_string_before.png86.22 KBao2
content_language_negotiation_processOutboud_no_query_string_before.png89.2 KBao2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ao2 created an issue. See original summary.

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented
Status: Active » Needs review
FileSize
content_language_negotiation_processOutboud_no_query_string_after.png91.17 KB
content_language_negotiation_processOutboud_with_query_string_after.png87.1 KB
LanguageNegotiationContentEntity_dont_break_interface_language_switcher_links-2864055-2.patch3.11 KB

I am attaching a patch which fixes the problem by marking the interface language switcher URLs in LanguageNegotiationUrl::getLanguageSwitchLinks(), so that LanguageNegotiationContentEntity::processOutbound() knows that they are to be left alone.

It is a hack, if you will, and it is meant only as a base for a discussion about how to fix the problem properly.

This is the end result, which I think is what the final solution should be targeting:

fixed content language negotiation processOutboud with no query string

fixed content language negotiation processOutboud with query string

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented
Issue summary: View changes

Explain better where the doc about Url::fromUri is.

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented
FileSize
LanguageNegotiationContentEntity_dont_break_interface_language_switcher_links-2864055-4.patch3.2 KB
interdiff-2864055-2-4-do-not-test.diff1.97 KB

Here's an update, changes since the patch in #2 (see also the interdiff):

  • specify the language type in the option used to mark language switcher links, this gives other language switchers more info to work with;
  • reword some comments and fix a typo.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at MD Systems GmbH commented
FileSize
2864055-test-only-FAIL.patch3.45 KB
2864055-7.patch6.95 KB
interdiff-4-7.txt4.18 KB

Not sure about the best approach either, but I have:

- confirmed the bug exists
- confirmed that the patch solves the issue
- rerolled the patch
- wrote a test for that

The last submitted patch, 7: 2864055-test-only-FAIL.patch, failed testing. View results

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented

@marcoscano, thanks for re-rolling and adding a test.

BTW have you also taken a look at #2863465: LanguageNegotiationContentEntity: make links to entities only change the content language by any chance?

Ciao,
Antonio

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

vredko’s picture

vredko CreditAttribution: vredko as a volunteer and commented
FileSize
language_negotiation_content_entity_dont_break_interface_language_switcher_links-2864055-13.patch.patch3.58 KB

Thanks @marcoscano for the patch. i've updated it for 8.9.x

james.williams’s picture

james.williams CreditAttribution: james.williams at ComputerMinds commented
Version: 8.9.x-dev » 9.3.x-dev
FileSize
core-language_negotiation_content_entity_dont_break_interface_language_switcher_links-2864055-14.patch3.51 KB

Re-rolled to apply to 9.3.x

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2864055-nr-bot.txt230 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.