#drupal-offcanvas should be a class selector. [#2861676]

While working on

https://www.drupal.org/node/2858879

I looked at the error logs and at Drupals shiny new feature of showing css lint error along with phpunit errors.

one error log is

https://www.drupal.org/pift-ci-job/623708

A feature of the changes in the issue is that it touches just about all drupal-offcanvas related css files.
and so can be regarded as a accidental lint check

The error logs has "516 coding standards messages"

the bulk of them can be wiped away if we convert the #drupal-offcanvas id selectors into a .drupal-offcanvas class selectors.

This issue should only be started after the parent is complete.

Comments

Comment #1

17 March 2017 at 19:20

martin107 created an issue. See original summary.

Comment #2

martin107 CreditAttribution: martin107 as a volunteer commented 20 March 2017 at 16:28

Assigned:

martin107

» Unassigned

In the interest of conversation,

here is a reasoned objection to this issue.

https://www.drupal.org/node/2858879#comment-11995483

Actually, even though this is technically a break with CSS coding standards it is *very* intentional that everything is scoped to the ID. It's using the ID that provides the extra level of specificity that enables us to (almost) isolate everything in the tray so that the front end theme does not bleed in.

This is relates to:#2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer which is how the seven theme will find its way to tray on the front end in the first place.

Without that scoping the reset just plain doesn't work and we'd need to find another technique (iFrame, CSS in javascript, webcomponents.js etc.) to achieve the same result.