Problem/Motivation

[#2847522} allows the user to choose the renderer for the settings tray but in order to sow up in the select the theme must have a library for the offcanvas tray.

Proposed resolution

Add an offcanvas library to Seven theme with styles that follow the Seven style guide.

Remaining tasks

Create patch

User interface changes

When Seven is selected for 'offcanvas admin renderer" the tray will be styled like seven theme

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tkoleary created an issue. See original summary.

tkoleary’s picture

Status: Active » Needs review
FileSize
90.86 KB

Initial commit

Status: Needs review » Needs work

The last submitted patch, 3: 2858879-seven-settings-tray-3.patch, failed testing.

tkoleary’s picture

Status: Needs review » Needs work

The last submitted patch, 5: 2858879-seven-settings-tray-4.patch, failed testing.

martin107’s picture

Status: Needs work » Needs review
FileSize
90.81 KB
1.24 KB

New York, New York so good they named it twice

When it comes to duplicating the keyword 'component' ... less so.

drupal.dialog.ajax:
  version: VERSION
  js:
    misc/dialog/dialog.ajax.js: {}
  css:
    base:
      misc/dialog/css/offcanvas.reset.css: {}
      misc/dialog/css/offcanvas.css: {}
    component:
      misc/dialog/css/offcanvas.motion.css: {}
      misc/dialog/css/offcanvas.form.css: {}
      misc/dialog/css/offcanvas.table.css: {}
      misc/dialog/css/offcanvas.details.css: {}
      misc/dialog/css/offcanvas.tabledrag.css: {}
    component:
      misc/dialog/css/offcanvas.theme.css: {}
  dependencies:
    - core/jquery
    - core/drupal
    - core/drupalSettings
    - core/drupal.ajax
    - core/drupal.dialog

Also fixed a small whitespace issue.

Status: Needs review » Needs work

The last submitted patch, 7: newYork-2858879-7.patch, failed testing.

tkoleary’s picture

@martin107 :)

Thanks, but apparently that's not what was causing the test failure.

martin107’s picture

The test count did actually go down!

misc/dialog/css/offcanvas.theme.css

was not included in the library definition correctly, I will try and unpick the last nit tomorrow.

[ BTW: I really appreciate how much time it takes to get a clear mental picture of how all this should cleanly fit together.]

martin107’s picture

A feature of the changes in the issue is that it touches just about all drupal-offcanvas related css files and so can be regarded as a accidental lint check

So I have spawned a side issue to convert "#drupal-offcanvas" into ".drupal-offcanvas" selectors.

martin107’s picture

While this will not solve the test error - I Just want to highlight some css that has become corrupted.

in offcanvas.reset.css

["button" i] is invalid css.

Then I think we need to follow the convention that some css files need to be copied into the stable directory structure
for backwards compatibility

https://www.drupal.org/node/2580687

input[type="button" i],
input[type="submit" i],
input[type="reset" i],
input[type="file" i]::-webkit-file-upload-button {
  -webkit-appearance: none;
  appearance: none;
  display: inline-block;
  background-image: none;
  border: 0;
  outline: 0;
  color: initial;
  overflow: visible;
  text-shadow: none;
  text-decoration: none;
  vertical-align: middle;
  cursor: pointer;
}
tkoleary’s picture

@martin107

So I have spawned a side issue to convert "#drupal-offcanvas" into ".drupal-offcanvas" selectors.

Actually, even though this is technically a break with CSS coding standards it is *very* intentional that everything is scoped to the ID. It's using the ID that provides the extra level of specificity that enables us to (almost) isolate everything in the tray so that the front end theme does not bleed in.

This is relates to:#2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer which is how the seven theme will find its way to tray on the front end in the first place.

Without that scoping the reset just plain doesn't work and we'd need to find another technique (iFrame, CSS in javascript, webcomponents.js etc.) to achieve the same result.

tkoleary’s picture

Status: Needs work » Postponed

Since this depends on #2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer which is postponed, postponing this as well.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

Status: Postponed » Closed (won't fix)

#2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer is closed as works as designed, so I guess this is not possible to fix.