Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
[#2847522} allows the user to choose the renderer for the settings tray but in order to sow up in the select the theme must have a library for the offcanvas tray.
Proposed resolution
Add an offcanvas library to Seven theme with styles that follow the Seven style guide.
Remaining tasks
Create patch
User interface changes
When Seven is selected for 'offcanvas admin renderer" the tray will be styled like seven theme
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2858879-4-7.txt | 1.24 KB | martin107 |
#7 | newYork-2858879-7.patch | 90.81 KB | martin107 |
#5 | interdiff-2858879-seven-settings-tray-3-4.txt | 40.84 KB | tkoleary |
#5 | 2858879-seven-settings-tray-4.patch | 90.83 KB | tkoleary |
#3 | 2858879-seven-settings-tray-3.patch | 90.86 KB | tkoleary |
Comments
Comment #2
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #3
tkoleary CreditAttribution: tkoleary at Acquia commentedInitial commit
Comment #5
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #7
martin107 CreditAttribution: martin107 as a volunteer commentedWhen it comes to duplicating the keyword 'component' ... less so.
Also fixed a small whitespace issue.
Comment #9
tkoleary CreditAttribution: tkoleary at Acquia commented@martin107 :)
Thanks, but apparently that's not what was causing the test failure.
Comment #10
martin107 CreditAttribution: martin107 as a volunteer commentedThe test count did actually go down!
misc/dialog/css/offcanvas.theme.css
was not included in the library definition correctly, I will try and unpick the last nit tomorrow.
[ BTW: I really appreciate how much time it takes to get a clear mental picture of how all this should cleanly fit together.]
Comment #11
martin107 CreditAttribution: martin107 as a volunteer commentedSo I have spawned a side issue to convert "#drupal-offcanvas" into ".drupal-offcanvas" selectors.
Comment #12
martin107 CreditAttribution: martin107 as a volunteer commentedWhile this will not solve the test error - I Just want to highlight some css that has become corrupted.
in offcanvas.reset.css
["button" i] is invalid css.
Then I think we need to follow the convention that some css files need to be copied into the stable directory structure
for backwards compatibility
https://www.drupal.org/node/2580687
Comment #13
tkoleary CreditAttribution: tkoleary at Acquia commented@martin107
Actually, even though this is technically a break with CSS coding standards it is *very* intentional that everything is scoped to the ID. It's using the ID that provides the extra level of specificity that enables us to (almost) isolate everything in the tray so that the front end theme does not bleed in.
This is relates to:#2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer which is how the seven theme will find its way to tray on the front end in the first place.
Without that scoping the reset just plain doesn't work and we'd need to find another technique (iFrame, CSS in javascript, webcomponents.js etc.) to achieve the same result.
Comment #14
tkoleary CreditAttribution: tkoleary at Acquia commentedSince this depends on #2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer which is postponed, postponing this as well.
Comment #25
longwave#2847522: Allow off-canvas links to be rendered by either "default" or "admin" renderer is closed as works as designed, so I guess this is not possible to fix.