D6 synchronized field settings aren't migrated properly

Updated issue summary noting that this is a Drupal 6 contrib feature, not a core feature.

This enables i18nsync in the fixture and has a source plugin and test to get the i18nsync% variables from the variable table. Still to do is a process and destination.

But I've not used synchronized fields and am not sure what is supposed to happen. The IS states to "Turn "synchronized fields" into untranslated fields in the D8 content translation settings" which seems straight forward but what if the synchronized field has translations then why would the content translation setting be set to untranslated?

Meant to add the patch. I don't know why but adding the synchronized fields added a lot of data to the fixture.

Re-parenting so that all multilingual migrations can be found from the same meta. Moved original parent to related issues.

Woohoo! At Drupal South @thomas.feichter showed and explained to me how synchronized fields work!

Triaging the issue queue.

Started using the Drupal 6 database created at Drupal South. It has once synchronized field, an email field, on the Company content type. I then added a text field to the same Content type and set it to synchronized. Then I looked into synchronized fields in Drupal 8 and came up with nothing. I see no setting nor did I find any docs or blogs etc.

So it seems that the value of a D6 synchronized field needs to be migrated to all the translations of the node. But what is the migration doing now, this issue was opened a long time ago and much has changed. To start I looked at the data for Company fields in the D6 db.

mysql> select * from content_type_company;
+------+-----+--------------------+-------------------------------------+
| vid  | nid | field_test2_email  | field_data_value                    |
+------+-----+--------------------+-------------------------------------+
| 2004 |  23 | french@example.com | Join us and work four days per week |
| 2005 |  24 | french@example.com | Join us and work four days per week |
+------+-----+--------------------+-------------------------------------+
2 rows in set (0.00 sec)

Ah, the field values are already duplicated for each field. This is likely to work correctly now without a new migration.

Just tested that by running a full migration using the UI and navigated to the Company nodes and the value for both synchronized fields is shown correctly on both nodes, the English and the French. Nice!

What next?

First, this needs to be tested by someone else to confirm the restuls. And if this is working for CCK fields then close this issue. I've uploaded the database used for testing this.

Second, do we know if this is working for other, non CCK, synchronized fields? In D6, on the Company content type, the following can be marked synchronized.

 Author
Status
Promote
Moderate
Sticky
Revision (Create also new revision for translations)
Book outline (with the translated parent)
Taxonomy terms
Comment settings
File attachments 

I'm looking into this a little more, but I believe this issue is more about the field settings not coming over properly than the content. The field should be marked as untranslatable, but the content does appear in the database correctly.

I believe this would be the test that needs to pass (though it should probably be moved into content_translation, now that I look at it)

gah..

Just some cleanup on the patch. Setting to NR to make sure new errors are not introduced.
This will need a migration to change the translation setting of the synchronized fields.

The D6 fixture has changed so this most likely needs a reroll.

Patch rerolled

The field instance migration is changed to include the translatable field and the source plugin determines the value in prepareRow(), it is set true unless this is a synchronized field.

The test file that mikelutz created has been removed and the assertion moved to MigrateNodeTest because MigrateNodeTest already does lots of assertions on the migrated fields. Tests have been added to MigrateFieldInstance as well.

I've got some fixes locally for this, just need some time to get it ready.

Hmm, that should be NW

This add i18nsync to the list of noUpgradePaths since it provides functionality, the source_module has not changed. Also the node type the sync field is on has been changed from company to employee because using company conflicted with the test MigrateLanguageContentSettingsTest.

Forgot the entity counts

Adjust the the other entity counters for the new field.

Last thing is to check the changes to the fixture. Can anymore be removed?

Double checked the changes to the fixture and I'm just not sure if all the changes to locales_source are needed. I know they are not needed for the tests but maybe they are needed when working via a Drupal 6 UI.

Ready for review.

The tiny test I submitted in #21 was completely rewritten, so I think I can still review this. The approach is correct, as are the tests that check it. I think the locales_source changes should be removed from the fixture. It will shrink the patch, and they are an easy enough hunk to remove. They aren't necessary for working in the UI, they just get inserted while working in the UI anytime t() encounters a new string. I think with them removed this is ready to go.

Thanks for explaining about locales_source.

Rather tired but I've gone ahead and removed that changes to locales_source. Let's hope my fingers are working well.

Looks good to go, and a more manageable size. Thanks!

Random test fail..

Looks good to me! Thanks all!