Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The file upload widget has some strange behavior when Inline Form Errors is enabled.
Issue is blocked by #2482783: File upload errors not set or shown correctly and #77245: Provide a common API for displaying JavaScript messages.
This can be tested after uploading a wrong file type.
With JavaScript:
- There is a hash link directly above the image, this should be removed.
- The important error is not inline, and a not needed error "this value should not be null" is shown inline.
- Minor importance: there is no new hash link at the top of the page to the error. (No blocker because the user doesn't has to search for the error on the page, it is right before him/her.
Without JavaScript enabled.
- The file type error is not inline
- In case that the file is required, the required message is also shown. When there is another error the required error shouldn't be shown./li>
Original issue:
Pulled from #435 from @dmsmidt written on April 15, 2015 at 5:12pm
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | file_upload_error_after_ife.png | 20.52 KB | dmsmidt |
| #3 | ife_images.png | 24.25 KB | dmsmidt |
Comments
Comment #3
dmsmidtRepurposed this issue after check of all mentioned problems, most seem to be gone.
The only problem left seems to be with the file upload widget, see new issue description.
And radio buttons styling: #2687251: Radios / Checkboxes focus styling wrong when marked as having an error
Comment #4
dmsmidtComment #5
dmsmidtPostpone, blockers need fix first.
Comment #6
dmsmidtInteresting related feedback by Alex Pott in #2482783-19: File upload errors not set or shown correctly.
Comment #7
dmsmidtBy fixing #2482783: File upload errors not set or shown correctly we are actually already a lot closer to what we want.
This is the result with IFE on:
The element is correctly marked as having an error and the error is inline.
Left over:
- Get rid of the summary at the top (for ajax partial submits)
- Nice to have: update or place the errors summary at the top of the page
Comment #9
dmsmidtClosing this in favor of #2876321: Update inline form errors summary after form validation with AJAX which fixes this issue in combination with #2482783: File upload errors not set or shown correctly.