Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
After uninstall the help module, the demonstrate block regions link is not displayed anymore on Block layout page.
Of course as a "smart" user you can go directly to /admin/structure/block/demo/{theme} and see the theme regions demonstration, but from the usability perspective this is a regression.
This problem not happen in drupal 7 because the owner of the hook_help() is the system module (always enabled) whereas in drupal 8 the owner of hook_help() is the optional help module
In my opinion demonstrate block regions link is a functional link not an help and it should not depends on help module
Proposed resolution
Display the demonstrate block regions link on Block layout even if help module is not enabled by making it an action button at the top of the page.
| Comment | File | Size | Author |
|---|---|---|---|
| place-blocks-from-listing.png | 69.25 KB | Bojhan | |
| #9 | interdiff.txt | 540 bytes | willzyx |
| #9 | demonstrate_block-2513580-9.patch | 5.5 KB | willzyx |
Comments
Comment #1
willzyx CreditAttribution: willzyx commentedin first place make fail BlockUiTest::testBlockDemoUiPage()
Comment #3
willzyx CreditAttribution: willzyx commentedComment #4
willzyx CreditAttribution: willzyx commentedMoving the demonstration link to BlockListBuilder can be a viable solution but changes a little the UI
Help module disabled
Help module enabled
Comment #5
willzyx CreditAttribution: willzyx commentedComment #6
webchickOh wow, nice find.
Comment #7
MattA CreditAttribution: MattA commentedComment #8
willzyx CreditAttribution: willzyx commentedrerolled after #2514998: Reduce fragility in the monolithic BlockListBuilder. Not sure if now ::buildForm() is the best palce for adding the link.
Comment #9
willzyx CreditAttribution: willzyx commentedFixed constructor comments
Comment #10
tim.plunkettPostponing this on #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block, after that goes in we can just make the "Demonstrate block regions" link into the primary action button on the page!
Comment #11
willzyx CreditAttribution: willzyx commentedReopening this issue since #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block was committed.
Comment #12
webchickNow we can actually fix this in a very simple way: let's make the "Demonstrate block regions" an action button at the top of the page. :) Two birds, one stone!
Comment #13
webchickComment #14
willzyx CreditAttribution: willzyx commented@webchick #2514150: Advertise the block region demonstration in a more prominent way already have a patch for this.. shoud we close this issue and work only on #2514150: Advertise the block region demonstration in a more prominent way?
Comment #15
webchickOh, good call. Yes, let's do that, thanks!