Follow-up to #2384675: Deprecate conf_path()

The parent issue missed usages of the deprecated conf_path() in InstallerExistingSettingsNoProfileTest which should be removed.

CommentFileSizeAuthor
#4 remove_usages_of-2503015-4.patch1.3 KBcilefen
#2 2503015-2.patch1.2 KBjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Fixed » Active
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Active » Needs review
FileSize
2503015-2.patch1.2 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Needs work 
+++ b/core/modules/system/src/Tests/Installer/InstallerExistingSettingsNoProfileTest.php
@@ -45,11 +46,11 @@ protected function setUp() {
+        'value' => DrupalKernel::getSitePath() . '/files/config_active',
...
+        'value' => DrupalKernel::getSitePath() . '/files/config_staging',

Let's call DrupalKernel::getSitePath() only once.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Needs review
FileSize
remove_usages_of-2503015-4.patch1.3 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented

Oh I didn't realize ::getSitePath will probably work. Oh no it won't. It isn't a static method.

The last submitted patch, 2: 2503015-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

@cilefen yep you're right - at this point - no container nothing we definitely have to use ::findSitePath()

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Closed (duplicate)
Related issues: +#2487592: CMI: don't ship with a default "active" directory that is empty in most Drupal installations

I've merged this patch into #2487592: CMI: don't ship with a default "active" directory that is empty in most Drupal installations to prevent unnecessary re-rolling and added the contributors to this patch to the suggested commit message on the other issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue tags: -Performance

Not a performance issue this one :)